search

CoEDL / elpis

🙊 software for creating speech recognition models.
https://elpis.readthedocs.io/en/latest/
Apache License 2.0
151 stars 33 forks source link

Formatted endpoints #284

Closed aviraljain99 closed 2 years ago

aviraljain99 commented 2 years ago

Please ignore the change in the dockerfile. I will remove it in the next commit to this PR - it was just for testing. But I have formatted the endpoints directory using black and that is the subject of this PR.

aviraljain99 commented 2 years ago

I was also wondering if any of you had any thoughts on the maximum line length that is enforced by black? The black default is 88 characters.

nicklambourne commented 2 years ago

I'm in favour of 100 char line lengths, 120 at most.

aviraljain99 commented 2 years ago

@nicklambourne I don't think the black formatter is setup within this repo - neither is it in the pyproject.toml dependency section (is it referred to as a closure?). I will look into it - also sorry for the late response.

aviraljain99 commented 2 years ago

@nicklambourne I have copied over the workflow from elpiscloud that runs the black formatter on the Python files so it should now run that workflow on pushes to master or when there is a PR into master.

I also added some black configuration info to the pyproject.toml file and set the line length to a 100 characters. Also black is now a dev dependency. Is this PR good to merge into master now?