CoEDL / nyingarn-workspace

The Nyingarn data ingest and preparation application
GNU General Public License v3.0
0 stars 0 forks source link

New mark up button linked to schema in workspace #118

Closed sophlew closed 2 months ago

sophlew commented 2 years ago

Please update Workspace with the following mark-up button and their scheme codes

@Conal-Tuohy please supply schema for line-marking, and song phrase

sophlew commented 2 years ago

Order list: underline, delete, unclear, paragraph, line, gap, rule, person name, place name, org name, graphic, supplied.

marcolarosa commented 2 years ago

I thought we were changing strikethrough to del?

marcolarosa commented 2 years ago

I've also implemented controls to remove markup and greatly cleaned up the code - which makes me feel much better about the long term maintenance and enhancement.

https://github.com/CoEDL/nyingarn-workspace/commit/4bc9003ec17a9e9e700accf20daba20c426cd302

Conal-Tuohy commented 2 years ago

@Conal-Tuohy please supply schema for line-marking, and song phrase

I will add this to the schema document, but just quickly; they will be:

For a rule*:

<milestone rend="rule"/>

NB as an aside, the <line> element is produced by some ingestion processes, but it's not an element which encoders should use themselves; they should use <p> to encode actual paragraphs, <list> and <item> for lists, etc, so we shouldn't provide a <line> button.

To encode a line of verse or song, the element <l> (for "line") is used.

An <l> element can appear on its own, just somewhere with a <p> of text. But more usually a group of these lines (an entire song, or a verse or a stanza) should be enclosed in an <lg> (line group) element.

Similarly, if it's desired, a bunch of <lg> can themselves be grouped into an <lg> (for grouping verses in a song).

<lg>
   <lg>
      <l>Once a jolly swagman camped by a billabong</l>
      <l>Under the shade of a Coolibah tree</l>
      <l>And he sang as he watched and waited till his billy boiled</l>
      <l>"You'll come a Waltzing Matilda with me"</l>
   </lg>
   <lg>
      <l>Down came a jumbuck to drink at that billabong,</l>
      <l>Up jumped the swagman and grabbed him with glee,</l>
      <l>And he sang as he shoved that jumbuck in his tucker bag,</l>
      <l>"You'll come a-waltzing Matilda, with me."</l>
   </lg>
   <!-- etc -->
</lg>
sophlew commented 2 years ago

Marco please go ahead with rule.

Conal-Tuohy commented 2 years ago

@sophlew can you provide a "song phrase" example or two please, so I can see it in context?

sophlew commented 1 year ago

User request for two new markup buttons: italics and indent