search

CoEDL / nyingarn-workspace

The Nyingarn data ingest and preparation application
GNU General Public License v3.0
0 stars 0 forks source link

Tidy up table markup in TEI files from oxgarage #68

Closed sophlew closed 2 years ago

sophlew commented 2 years ago

Tested the SLNSW example @Conal-Tuohy I showed you yesterday with tables. The result in the workspace delivers lots of code around the transcription that is difficult for the user. You have the word document ready. I only tested one page, see SLNSW_FL814-355 and the screenshot. Can we discuss @nthieberger @marcolarosa different view options for the user.

  1. with code and 2. without code and allow the user to switch between and/or
  2. presenting the transcription text and code as different colours in the transcription box Screenshot (246)
Conal-Tuohy commented 2 years ago

I think we need to have different github issues for what I think are four different tasks:

  1. change ingestion of <table> markup to format it on multiple lines, with indentation etc, to improve readability (existing issue #35 I think covers the issue with the crufty text-align:left which should have been removed already).
  2. enable syntax highlighting for the transcription text box (this is just a feature of codemirror which we aren't using), including providing codemirror with a schema for autocompletion
  3. add an "HTML presentation" view where the XML markup is converted to HTML for meaningful display, run in the browser so it's a "live" display of the XML being edited
  4. changes to the layout of the various views (facsimile, text+markup, and HTML presentation) on the workspace page, including potentially moving the toolbar from the side to the top, perhaps allowing the user to show or hide each view, move them, resize them etc.

These issues are all related in the sense that they all have an impact of the user experience of working with tables, but they're all independent tasks and affecting different parts of the codebase.

Let's keep this issue for the first of these, and I'll open three more.

Conal-Tuohy commented 2 years ago

Created new issues to track the other tasks originally raised in this issue:

Conal-Tuohy commented 2 years ago

Change normalise-docx-via-oxgarage.xsl to add new lines around table and row elements:

    <!-- insert newline characters before each block element for improved readability -->
    <xsl:template match="div | head | p | item | label | note | table | row" mode="docx-via-oxgarage">
marcolarosa commented 2 years ago

Closing ticket as it seems to have been superseeded by other tickets.