search

CoMPaTech / stromer

Stromer custom_component for Home Assistant
MIT License
17 stars 5 forks source link

Name of battery_condition entity #133

Open dbrgn opened 2 months ago

dbrgn commented 2 months ago

Describe the bug.

I noticed that the SOH (state of health) of the battery is sent by the API as battery_health, but the sensor in HomeAssistant is named battery_condition.

Is there any reason for the rename? SOH is a well-established term in relation to batteries, so if there's no reason to deviate from the manufacturer terminology, I'd try to avoid that and name the sensor battery_health.

(Of course if you think otherwise for whatever reason, feel free to close this issue, no hard feelings 🙂)

What version of Home Assistant Core has the issue?

2024.8.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Supervised

How did you install the stromer integration

Manually installed custom_component

Logging

No response

Diagnostics information

No response

Additional information

No response

CoMPaTech commented 2 months ago

Hi @dbrgn not sure why I did that some time ago, make sense to just follow the standard indeed.