EBS: found additional locations where branding remains "OBS"

[chadfurman]

• C:\Users\chad\projects\EBS\OBS-studio-webrtc
• C:\Users\chad\AppData\Roaming\obs-studio
• C:\Program Files\EBS Studio (64bit)\obs-plugins
• C:\Program Files\EBS Studio (64bit)\data\libobs
• C:\Program Files\EBS Studio (64bit)\data\obs-plugins
• C:\Program Files\EBS Studio (64bit)\data\obs-studio
• multiple files in the include folder ...

Curious about why, LOE to fix, etc

I'm guessing at this point it's because we're doing a skin layer as opposed to a search-and-replace on the string, right?

[agouaillard-cosmo]

What does LOE stand for?

[chadfurman]

LOE stands for level of effort

[agouaillard-cosmo]

You should make sure to test with a "fresh install", which for us means an installation on a computer that never had neither EBS or OBS installed before (e.g. a VM on AWS). That would help you avoid egregious mistake when brutally searching for a string.

• C:\Users\chad\projects\EBS\OBS-studio-webrtc This is your local clone of the GitHub repository, it has nothing to do with the installed version.
  • C:\Users\chad\AppData\Roaming\obs-studio This could be a remnant of a previous installation, as uninstalling OBS or EBS does not remove the data folder. This is considered an "internal implementation" detail, as, unless you're a developer, you won't touch that.
  • C:\Program Files\EBS Studio (64bit)\obs-plugins Everything inside the install directory is supposed to be "internal implementation" detail, and using "obs" in the name of anything but the main executable was deemed ok.
  • C:\Program Files\EBS Studio (64bit)\data\libobs
  • C:\Program Files\EBS Studio (64bit)\data\obs-plugins
  • C:\Program Files\EBS Studio (64bit)\data\obs-studio

The line was drawn for modification at everything the is user visible. In terms of files on the hard disk, the name of the main executable, and the link in the usual places for it (like the start menu for windows), were designed as sufficient in terms of branding.

Note that changing the names of classes, and of files, to remove the string "obs", is not only a daunting task, but it is also not recommended as you diverge greatly from the code base, and it will make the maintenance a nightmare.

[chadfurman]

What I deemed sufficient was that "obs" strings before build/packaging were acceptable as the end-user would never see those strings. "OBS" strings once the application is installed on an end-user's computer are definitely visible to the end user because: 1) to properly flush settings, you must delete the settings folder. This folder is the "obs-studio" folder in the AppData directory 2) Given that the start menu doesn't work, the user is encouraged to open up the Program Files folder directly and from there it's not a stretch that the user would see the obs labels on the includes

As for the maintenance burden, perhaps there's a strategic way to approach this. Something like a find-replace at build time or similar. This does not address the fact that this is a daunting task, however.

• C:\Users\chad\projects\EBS\OBS-studio-webrtc -- you are correct, this is my local clone. Thank you
• As for the rest, these are end-user visible.

Let's leave this ticket open for now, as this hasn't come up yet in discussions with the client but it would not surprise me if they do eventually notice and raise it as a concern...

[agouaillard-cosmo]

"Let's leave this ticket open for now, as this hasn't come up yet in discussions with the client but it would not surprise me if they do eventually notice and raise it as a concern..."

Usually it's better to close the tickets untill a real problem arise, so we can focus on tickets which represent problem that really need to be addressed.

I will go ahead and close this ticket. Please re-open it if it becomes a real problem with any customer.