search

CoSMoSoftware / OBS-studio-webrtc

This is a fork of OBS-studio with generic support for webrtc. It leverages the same webrtc implementation most browsers use.
http://www.cosmosoftware.io
GNU General Public License v2.0
593 stars 130 forks source link

OBS reports 0KB/s when using webrtc #24

Closed agouaillard-cosmo closed 6 years ago

agouaillard-cosmo commented 6 years ago

romain, can you investigate this? likely the webrtc bandwidth estimation or corresponding stat (better) is not wired with the UI or tool.

cosmo-rn commented 6 years ago

problem fixed

agouaillard-cosmo commented 6 years ago

wait, how did you fix it, and how to check/validate it? I on; t see any commit referenced here. ( to have a commit appear in a ticket thread insert the ticket number in the commit message. For this ticket it would mean e.g. adding a #24 at the end of the commit message).

agouaillard-cosmo commented 6 years ago

Note for romain: since this is a bug, you should use [FIX] and not [ENH]. commit 35b01b6 @bogenpirat can you kindly check if this address the problem you originally reported?

bogenpirat commented 6 years ago

@agouaillard-cosmo Thanks for the heads up. Unfortunately I'm unable to test this right now as I've run into some trouble setting up the toolchain for compilation. The server/consumer end are set up though, so if you happen to have time to compile a binary, I'd love to report back how it performs.

agouaillard-cosmo commented 6 years ago

@cosmo-rn can you prepare a release in https://github.com/CoSMoSoftware/OBS-studio-webrtc/releases

cosmo-rn commented 6 years ago

Sorry for the wait. The release is now available. https://github.com/CoSMoSoftware/OBS-studio-webrtc/releases/tag/2.0

bogenpirat commented 6 years ago

I can report that bandwidth displays properly (and accurately).

agouaillard-cosmo commented 6 years ago

Thanks for validating.