search

Coastal-Imaging-Research-Network / CIRN-Quantitative-Coastal-Imaging-Toolbox

The CIRN Introduction to Quantitative Coastal Imaging Toolbox is a collection of MATLAB scripts to produce geo-rectified images specifically tailored for quantitative analysis of coastal environments.
GNU General Public License v3.0
19 stars 7 forks source link

Minor typos #19

Closed csherwood-usgs closed 4 years ago

csherwood-usgs commented 4 years ago

Hey Brittany, This is an awesome toolbox! I have successfully used it to do extrinsic calibrations and rectifications of our camera on the outer Cape: https://usgs.gov/caco01. Everything is easily laid out, and it is easy for my summer students to follow the steps. I have only found two typos, and my only other comment is that it would be nice to indent the code...and that is so easy in Matlab: ctrl-a, ctrl-i.

The typos are in C_singleExtrinsicSolution.m: line 155 - Shouldn't that be "World Y Axis" line 165 - Now in Section 5

Great job! Chris

csherwood-usgs commented 4 years ago

Do you know if anybody has translated the rectification functions to Python?

burritobrittany commented 4 years ago

Thanks @csherwood-usgs !!!

Thank you so much for the feedback! We have not translated them. However, you are not the first to ask. I will ask around with my python friends :)

Best, Brittany

burritobrittany commented 4 years ago

Didn't know about that cool indent trick! Thanks!