search

Coastal-Imaging-Research-Network / cBathy-Toolbox

Routines needed to run cBathy + demos
https://github.com/Coastal-Imaging-Research-Network/cBathy-toolbox/wiki/cBathy-User-Manual
GNU General Public License v3.0
25 stars 23 forks source link

Version 1.2 #29

Closed jstanleyx closed 6 years ago

jstanleyx commented 6 years ago

Implements changes to convert 1.1 into 1.2. Includes seam fix and new initialization function.

this was originally branch js-most-recent and had a pull request against development. this needs to go to master first, and then development can be re-branched from version 1.2

development and master are currently identical. when pull request #28 from version-1.1 is merged, the only difference between master and development will be the version number.

KateBrodie commented 6 years ago

I have run the same file through v1.1 (Master) and v1.2 (This branch).

A few things; (1) the comments in analyzeBathyCollect should be updated to explain the cam variable (i.e. a vector of which camera the pixel stack was derived from' (2) the camUsed field needs to be added to the bathy output documentation

I have made the above fixes (see commit above). @jstanleyx @RobHolman if you agree with the minor edits I made to the comments in the commit above, I will approve the merge.

Below is a figure documenting the differences for the argus02b file (1441729740.Tue.Sep.08_16_29_00.GMT.2015) I tested: image

jstanleyx commented 6 years ago

Yep, comments on input needed.

I don't think you need to refer to the version since people using anything before 1.2 don't get cam or camUsed, but that's minor.

Looks good to me.

Since version-1.1 has been merged, there should be no more changes to it as a historical record. I've protected it so it won't go away by accident. (I see that there is a V1.1 tag on master, but this is backup.)

Once version-1.2 has been merged, I'll do the same to it.

On Tue, 2017-12-12 at 15:21 -0800, Katherine Brodie wrote:

I have run the same file through v1.1 (Master) and v1.2 (This branch).

A few things; (1) the comments in analyzeBathyCollect should be updated to explain the cam variable (i.e. a vector of which camera the pixel stack was derived from' (2) the camUsed field needs to be added to the bathy output documentation

I have made the above fixes (see commit above). @jstanleyx @RobHolman if you agree with the minor edits I made to the comments in the commit above, I will approve the merge.

Below is a figure documenting the differences for the file I tested: image

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

KateBrodie commented 6 years ago

@jstanleyx sounds good.

Yes, I did the official 1.1 release. From my understanding, I think keeping the older version branch is redundant once it's tagged, but since we're new to this, I guess redundancy may be a good thing :)