Sbfrf contribution guidelines

Coastal-Imaging-Research-Network / cBathy-Toolbox

Routines needed to run cBathy + demos

https://github.com/Coastal-Imaging-Research-Network/cBathy-toolbox/wiki/cBathy-User-Manual

GNU General Public License v3.0

25 stars 23 forks source link

Sbfrf contribution guidelines #46

Closed SBFRF closed 1 year ago

SBFRF commented 6 years ago

This request is not ready for merge

Tasks left before merge:

Establish test procedure from CIRN meeting discussions this is related to PR 29 from the wiki

SBFRF commented 6 years ago

https://github.com/mwgeurts/unit_harness Here's something that might be worth looking at for testing procedures. There's nice directions for implementation, but some test files would need to be created.

SBFRF commented 6 years ago

@SRHarrison @KateBrodie @mpalmsten Did we ever come to a conclusion on what testing would be required to merge into both development and into master. My thoughts are they should be 2 different requirements, but I don't know that we ever established this. We also discussed regression testing @thesser1 has a better understanding of the regression testing needs and how to set it up

We also could create a separate the testing into a new issue and merge this PR in so some rules would be in place

eswanson-usgs commented 2 years ago

Should not be merged into master, should be merged into development first

SBFRF commented 2 years ago

@eswanson-usgs why don't we change PR to merge to development rather than closing the PR?

eswanson-usgs commented 2 years ago

@eswanson-usgs why don't we change PR to merge to development rather than closing the PR?

Hi Spicer, I merged a new pull request yesterday into development. I didn't realize I could just use the edit button at the top of the page to change the target branch, that one's my bad. Is it okay if I close this PR since the commits have already been merged?