Closed RobHolman closed 5 years ago
@RobHolman
This pull request will need to be resubmitted into development - we never pull directly into master. That means before it can be approved you will need to merge development into your branch and then reconcile your fix vs. the fix submitted by @dahonegger in pull request #35 that was already merged into development.
In the mean-time I will start testing your branch. Which file do you intend to use for the demos? The three that are labeled "demo*.m"?
@RobHolman , @KateBrodie
I'm testing your branch. Here's what I found
original demoCBathy.m works as expected
new demo with stack from 10/09/15 ran in debug mode and produce phase maps with 3 colormaps (not sure why). Note that filled circles that Kate added with a pull to the development branch are not in this branch.
-demoExamineInputMovie.m failed when it called useInterpMap2.m, which does not exist in the repo (useInterpMap.m does exist)
-demoKalmanFiltering.m works as expected
-examineInputDataDemo.m works as expected, although it is awkward to switch back and forth between the demo code and the debugging in analyzeBathyCollectNotCIL.m. I think it may be confusing to students... but I'm not sure how to make if flow more smoothly.
In airport for early flight. Thanks for checking codes. Will fix missing routine. See you soon.
Sent from my iPhone
On Jun 12, 2019, at 8:54 PM, mpalmsten notifications@github.com wrote:
@RobHolman , @KateBrodie
I'm testing your branch. Here's what I found
original demoCBathy.m works as expected
new demo with stack from 10/09/15 ran in debug mode and produce phase maps with 3 colormaps (not sure why). Note that filled circles that Kate added with a pull to the development branch are not in this branch.
-demoExamineInputMovie.m failed when it called useInterpMap2.m, which does not exist in the repo (useInterpMap.m does exist)
-demoKalmanFiltering.m works as expected
-examineInputDataDemo.m works as expected, although it is awkward to switch back and forth between the demo code and the debugging in analyzeBathyCollectNotCIL.m. I think it may be confusing to students... but I'm not sure how to make if flow more smoothly.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
I changed the call to useInterpMap2 back to useInterpMap.
Rob Holman SECNAV/CNO Chair in Oceanography
104 Ocean Admin Bldg. CEOAS-OSU Corvallis, Oregon, USA 97331-5503 ph: 1-541-737-2914 holman@coas.oregonstate.edu http://cil-www.coas.oregonstate.edu
On Jun 12, 2019, at 8:54 PM, mpalmsten notifications@github.com wrote:
@RobHolman , @KateBrodie
I'm testing your branch. Here's what I found
• original demoCBathy.m works as expected
• new demo with stack from 10/09/15 ran in debug mode and produce phase maps with 3 colormaps (not sure why). Note that filled circles that Kate added with a pull to the development branch are not in this branch.
-demoExamineInputMovie.m failed when it called useInterpMap2.m, which does not exist in the repo (useInterpMap.m does exist)
-demoKalmanFiltering.m works as expected
-examineInputDataDemo.m works as expected, although it is awkward to switch back and forth between the demo code and the debugging in analyzeBathyCollectNotCIL.m. I think it may be confusing to students... but I'm not sure how to make if flow more smoothly.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
…a set 100915Etc.
Not totally sure what I am doing. But: