Coastal-Imaging-Research-Network / cBathy-Toolbox

Routines needed to run cBathy + demos
https://github.com/Coastal-Imaging-Research-Network/cBathy-toolbox/wiki/cBathy-User-Manual
GNU General Public License v3.0
25 stars 23 forks source link

Fix cBathy Angle Seed #54

Closed KateBrodie closed 2 years ago

KateBrodie commented 5 years ago

@bergsmaE @RobHolman

Here is a space for you to discuss and test new approaches for determining the seed angle in findKAlphaPhiInit.m.

Please post any results/figures for us all to see here!

bergsmaE commented 5 years ago

Ok, I did some first tests on data I have from Porthtowan and it seems very promising. I can get the incident wave angle. Bear in mind that this is for nice swell.

angleSeedRadon_radonTestset_001

Shore normal case: angleSeedRadon_radonTestset_003

Note: I do use all the pixels in the tile (so not limited by params.maxNPix)

@RobHolman , can you send me the xy and v related to the tile and case where the problem of the alphaSeed occured?

Thanks,

Erwin

bergsmaE commented 5 years ago

I have worked a bit on the plotting of the results of the cases above and the provided "problem" case. It seems to work pretty well: angleSeedRadon_radonTestset_003 angleSeedRadon_radonTestset_001 angleSeedRadon_exampleTestData1015151300GMT

@RobHolman if you have more special cases, please send them to me. I will finish the script that has as input "v" and an angle seed as output.

ADDED makeAlphaSeed.m to the branch (radon_alpha_seed)--> gives angle in radians

Cheers,

Erwin

bergsmaE commented 5 years ago

Clearly, I have no idea what I am doing with gitHub, apparently, I closed the issue :-), luckily I could reopen it.

KateBrodie commented 5 years ago

@bergsmaE this is looking great!

@RobHolman & @bergsmaE when you have tested enough "problem" cases and are happy with it, please then submit a pull request to merge this back into development. Tag someone to test it, and then we will run this on the cases from the original cBathy paper to make sure we aren't suddenly getting vastly different or incorrect results.

bergsmaE commented 4 years ago

@KateBrodie Did we do a pull request already for the alphaSeed?

I think we @RobHolman, tested it I haven't found any issues after with other datasets.

mpalmsten commented 2 years ago

alphaSeed is available in v2.0.