search

Coastal-Imaging-Research-Network / cBathy-Toolbox

Routines needed to run cBathy + demos
https://github.com/Coastal-Imaging-Research-Network/cBathy-toolbox/wiki/cBathy-User-Manual
GNU General Public License v3.0
25 stars 23 forks source link

sName Bug Fix #55

Closed burritobrittany closed 5 years ago

burritobrittany commented 5 years ago

Hi all, I have been trying to run the Master democBathy.m and I have been running into the issue that it crashes on 

Error in democBathy (line 10)
bathy = analyzeSingleBathyRunNotCIL(stackName, stationStr);

Error in analyzeSingleBathyRunNotCIL (line 33)
bathy = analyzeBathyCollect(xyz, t, data, cam, bathy);

Error in analyzeBathyCollect (line 55)
str = [bathy.sName(16:21) ', ' bathy.sName(36:39) ', ' bathy.sName([23 24 26 27])];

It seems it is trying to pull a string from a traditional mBW file name. It breaks on my computer for the development branch as well. It does not break on RobUpdates061119. In that branch it just comments out line 55 in analyzeBathyCollect and that seems to make it work.

So I guess it can be one of two issues.... 1) Something is going on with Rob's and my computers that does not allow the code to work. 2) This was an issue we kept fixing on site of the bootcamp and just never implemented into master/development.

I think it is (2). The variable 'str' in line 55 is just used for progress bar title and not passed along to anything else. So I deleted 'str' and just changed the title to be 'Cumulative Progress.'

This is not really a big deal however it would be nice for it to work for users who have not attended the bootcamp. Also...I wanted to practice my githubbing ;)

burritobrittany commented 5 years ago

Realized it was submitted to master and not development. Will close and reopen.

RobHolman commented 5 years ago

I agree with your issue and fix. I have previously this but likely screwed up the GitHub thing.