CoastalHacking / semiotics-main

Semiotics models and stand-alone product / UI
Apache License 2.0
0 stars 0 forks source link

Convert product launcher into feature-based versus plugin-based #12

Open jpasski opened 8 years ago

jpasski commented 8 years ago

From @jonpasski on March 29, 2016 14:20

Copied from original issue: OpenSemanticsIO/semiotics-main#16

jpasski commented 8 years ago

There are three concerns w/ this issue:

  1. The product launch configuration (Run Configurations...)
  2. The product's Product Configuration EditorOverviewLaunch an Eclipse application
  3. The Maven / Tycho build

Point 1 works because the .product plugin is included. So when the launch configuration is ran, the plugin is resolved. The i.o.s.m.product (product plugin) is required because the launch configuration is running it via OverviewProduct Definition section.

Point 2 works when the product plugin is included in the i.o.s.m.feature plugin (feature plugin). It does not work when it's not included.

Point 3 is the inverse of Point 2. Tycho builds just fine when the product plugin is not required by the feature plugin. Else, it fails.

Given that Point 2 is required, this seems more about making Tycho work than anything.

jpasski commented 8 years ago

Given that Point 2 is required, this seems more about making Tycho work than anything.

Maybe the eclipse-repository packaging type occurs during a different Maven lifecycle after verify?