CoastalResilienceNetwork / GeositeFramework

Mapping Framework powering TNC Coastal Resilience programs
http://maps.coastalresilience.org/network/
GNU General Public License v3.0
13 stars 10 forks source link

Add OSM basemap option #1098

Closed fungjj92 closed 6 years ago

fungjj92 commented 6 years ago

Overview

We offer a lot of basemaps the user can select from, but not OSM surprisingly. This PR adds the ability to select an OSM layer as the basemap. It's hard to find older JS API documentation but I think the OSM layer feature has existed for some time. The issue refers to OSM capability that was added since v3.24, which I'm guessing refers to the new OSM vector tile basemap which I don't imagine we will use.

Connects #1082

Demo

screen shot 2018-09-05 at 9 33 09 am screen shot 2018-09-05 at 9 33 26 am

Notes

Note this branch was built on top of the js api upgrade branch, following the assumption in the issue. I don't think it is dependent on the upgrade after all, but doesn't hurt to continue to merge it as so.

Testing Instructions

Pull down this branch and refresh in the browser. The layer selector should include OSM and it should be selectable.

If OSM doesn't show up in the dropdown, it may be that visual studio cache has clogged up. I had to exit VS and reopen my project once to get the changes to take.