fungjj92
commented
5 years ago Cherry-picked the commit onto develop in #1152. Prefer that PR over this one.
Closed fungjj92 closed 5 years ago
fungjj92
commented
5 years ago Cherry-picked the commit onto develop in #1152. Prefer that PR over this one.
Overview
TNC reported a bug (see #1142 for gif) whereby switching from a regional to a global view in the map made the map very tiny, offset, and cut off. Very odd.
From the best of my investigation, it seems like a mixture of problems some our code, some behind the scenes ESRI map CSS. A quick fix that seemed to work was setting a minimum zoom on the map such that we can't zoom out enough to encounter the issue. This seems like an overall positive move because there's no use to see the map so zoomed out and we avoid black space views like:
Connects #1142
Demo
Notes
Even though this is a Task 4 contract bug fix, I based and pointed this branch at the static site feature branch for easier testing. If we would rather cherry-pick the commit onto master, I can do that.
Testing Instructions
There's a lot of ways you could test this. Here's two easier ones:
From the
GeositeFrameworkrepo:developmentbranch of the natural-coastal-protection plugin (defaults to master, which won't build)region.jsonto include the natural-coastal-protection plugin in single plugin modepython ./scripts/server.pyor &-dStatic site build from the
geosite-framework-buildrepo,static-sitebranch:output folder(rm -rf output/)python build.py coastal-protection-region --framework-branch jf/bugfix#1142 --region-branch developmentcd output,unzip coastal-protection.zip,python -m SimpleHTTPServer 7979)You shouldn't see the issue anymore, and the minzoom should be enforced with no detriment to the map.