search

CoastalResilienceNetwork / GeositeFramework

Mapping Framework powering TNC Coastal Resilience programs
http://maps.coastalresilience.org/network/
GNU General Public License v3.0
13 stars 10 forks source link

Merge static site branch into develop branch #1166

Closed caseycesari closed 5 years ago

caseycesari commented 5 years ago

Overview

Merges the static site branch into the develop branch.

Testing instructions

fungjj92 commented 5 years ago

Quick note before testing, the README can use an update :) It captures the state of conversion from ASP.NET.

caseycesari commented 5 years ago

README updated!

fungjj92 commented 5 years ago

I'm checking the app on Chrome only, so far, and looking good on web mode. The navbar acts a little funny on mobile. Don't remember that, but also don't not remember that.

screen shot 2018-12-21 at 11 53 43 am screen shot 2018-12-21 at 11 57 34 am
caseycesari commented 5 years ago

Good find. Looks like something got lost or added during the merge. I'll check it out.

fungjj92 commented 5 years ago

No map on ie11 😮

screen shot 2018-12-21 at 12 07 07 pm
caseycesari commented 5 years ago

Good catch! Just pushed a fix for IE.

fungjj92 commented 5 years ago

IE and README look good ~ Also checked FF, and it behaves the same as I observed for Chrome. Once mobile fixed, this is good to go 👍

caseycesari commented 5 years ago

@fungjj92 Pushed a fix for the mobile issues. See commit message for details. Good catch! This is actually a bug that was already in production.

fungjj92 commented 5 years ago
screen shot 2018-12-21 at 1 19 41 pm

the navbar is fixed and works. the controls are cut off and the buttons content/map no longer come up at the bottom of the screen. is this correct?

fungjj92 commented 5 years ago

Oh that's right. Those styling elements are for single plugin app mode. Just tested SPA.

Nice work, and quick to the fixes! 👍