CoastalResilienceNetwork / GeositeFramework

Mapping Framework powering TNC Coastal Resilience programs
http://maps.coastalresilience.org/network/
GNU General Public License v3.0
13 stars 10 forks source link

Google Analytics Framework Issue #1176

Closed laflessn closed 5 years ago

laflessn commented 5 years ago

The code for GA is pulling googleUrlShortenerApiKey in region.json which is the wrong property, it should be using the googleAnalyticsPropertyId. Offending code is located: https://github.com/CoastalResilienceNetwork/GeositeFramework/blob/develop/src/template_index.html, line 155 and 163

The build is compiling the Analytics Property Id incorrectly. For example, if you look at the index.htm file where the GA stuff is inserted, the property ID listed is: ga('create', 'UA-AIzaSyDO_xBd3griGKuhlYBvv7jVN4Mt58Gl4iw', 'auto'); It should be: ga('create', 'UA-7401895-41', 'auto'); Cross-reference with region.json and: "googleAnalyticsPropertyId": "7401895-41", "googleUrlShortenerApiKey": "AIzaSyDO_xBd3griGKuhlYBvv7jVN4Mt58Gl4iw"