search

CoastalResilienceNetwork / GeositeFramework

Mapping Framework powering TNC Coastal Resilience programs
http://maps.coastalresilience.org/network/
GNU General Public License v3.0
13 stars 10 forks source link

Single web update #1179

Closed cbessee closed 5 years ago

cbessee commented 5 years ago

Hey @cschneebeck,

I talked with Laura yesterday, and it sounds like you've volunteered to be the "gate-keeper" so to speak of the framework master branch. So, here's my first pull request :) Let me know if you'd rather pull this into development first and I can re-submit.

Likewise, let me know if you have any questions about the code as you dig in. More than happy to hop on a quick screen share and talk through things if that would be helpful.

Thanks!

Overview

This pull request contains updates to the framework to improve the mobile responsive aspects of the "single web app mode" as well as support for Esri Feature Layers to enable user interaction with map features.

In general, we did our best to move away from using JS code for responsiveness and instead utilize JS to assign classes and provided updated html/css for a smoother, more performant mobile experience.

Updates

Development tasks for this set of updates were managed via a Trello board.

The following is a list of improvements/feature updates included in this pull request:

Preview URL

A demo of the Natural Coastal Protection app running in SWA mode of this framework branch can be viewed here

Testing

I've tested this framework branch in the following configurations:

In general, I feel good about the level of testing around these updates but it would certainly be good to get a second set of eyes on things. Especially someone with more familiarity with other apps not developed by SpatialDev/Critigen in the past to make sure these updates don't have any unintended consequences for other apps.

cschneebeck commented 5 years ago

Hi Coal,

I think Laura was hoping that you work with me on this one. I did a quick test on some another app and think it would be a good idea to chat about this. Let me know your preferred meeting platform.

Cheers, Casey Schneebeck Web Developer | The Nature Conservancy - North America Region | 415-722-9768

From: Cole Bessee notifications@github.com Reply-To: CoastalResilienceNetwork/GeositeFramework reply@reply.github.com Date: Tuesday, April 23, 2019 at 12:32 PM To: CoastalResilienceNetwork/GeositeFramework GeositeFramework@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [CoastalResilienceNetwork/GeositeFramework] Single web update (#1179)

Hey @caseycesarihttps://github.com/caseycesari,

I talked with Laura yesterday, and it sounds like you've volunteered to be the "gate-keeper" so to speak of the framework master branch. So, here's my first pull request :) Let me know if you'd rather pull this into development first and I can re-submit.

Likewise, let me know if you have any questions about the code as you dig in. More than happy to hop on a quick screen share and talk through things if that would be helpful.

Thanks!

Overview

This pull request contains updates to the framework to improve the mobile responsive aspects of the "single web app mode" as well as support for Esri Feature Layershttps://developers.arcgis.com/javascript/3/jsapi/featurelayer.html to enable user interaction with map features.

In general, we did our best to move away from using JS code for responsiveness and instead utilize JS to assign classes and provided updated html/css for a smoother, more performant mobile experience.

Updates

Development tasks for this set of updates were managed via a Trello boardhttps://trello.com/b/zxmX4wHb/tnc-framework-tasks.

The following is a list of improvements/feature updates included in this pull request:

Preview URL

A demo of the Natural Coastal Protection app running in SWA mode of this framework branch can be viewed herehttp://tnc-framework-dev.s3-website-us-west-2.amazonaws.com/

Testing

I've tested this framework branch in the following configurations:

In general, I feel good about the level of testing around these updates but it would certainly be good to get a second set of eyes on things. Especially someone with more familiarity with other apps not developed by SpatialDev/Critigen in the past to make sure these updates don't have any unintended consequences for other apps.

You can view, comment on, or merge this pull request online at:

https://github.com/CoastalResilienceNetwork/GeositeFramework/pull/1179https://github.com/CoastalResilienceNetwork/GeositeFramework/pull/1179

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/CoastalResilienceNetwork/GeositeFramework/pull/1179, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACXKVQTLG732VIGTM2ZIRWTPR5I5FANCNFSM4HH5KRKA.

cbessee commented 5 years ago

Hey @cschneebeck,

Ah - yes, of course. I should really double check who I am tagging before I hit send...

I can set up a Zoom call for us to screen share/discuss. I'm out of the office tomorrow, but available anytime this Thursday or Friday. Can you shoot me an email with a time that will work well for you? cole.bessee@critigen.com

Thanks!

cbessee commented 5 years ago

Hey @cschneebeck,

I've added some commits to this branch and merged in master to incorporate the update to rebrandly for URL shortening. I had to hardcode the PROD build flag to true as I wasn't able to pass this variable to the server.py or run a build via terminal's localhost:8080 without main.py throwing an error. Laura mentioned you are out on vacation. Let me know when you are back and we can hopefully schedule another quick call to discuss the best way for me to handle this and any other integration points for my updates? Thanks!

cschneebeck commented 5 years ago

All looks good. I merged the changes into develop