search

CoastalResilienceNetwork / GeositeFramework

Mapping Framework powering TNC Coastal Resilience programs
http://maps.coastalresilience.org/network/
GNU General Public License v3.0
13 stars 10 forks source link

Search placeholder i18n code isn't working on js-api-4x-pilot branch #929

Open kellyi opened 7 years ago

kellyi commented 7 years ago

The code in this routine:

https://github.com/CoastalResilienceNetwork/GeositeFramework/blob/js-api-4x-pilot/src/GeositeFramework/js/Map.js#L258

shows an error message on the pilot branch because search.get("sources") seems to return undefined. I opened #928 to disable it temporarily to silence the error message, but it may be straightforward to fix.

kellyi commented 7 years ago

From a comment on #928:

The search box doesn't have the same custom styling as applied on develop, but it looks like that's because it's constructed a bit differently in 4.x, and is missing a class (plus maybe more, adding the class didn't apply the same style). This may also explain why sources error was occuring on it as well. I don't think it's worth it to run this to the ground now. It'll looking pretty good for its intended use.