Fix UI issues with "i" icon and layer tools menu icon.

CoastalResilienceNetwork / regional-planning

ArcGIS and WMS map layer plugin for the GeositeFramework

0 stars 2 forks source link

Fix UI issues with "i" icon and layer tools menu icon. #52

Closed caseycesari closed 8 years ago

caseycesari commented 8 years ago

Fixes issues with layer icon highlight state. See commit messages for details.

Testing

Activate the Regional Planning plugin.
Hover over a layer and click the "i" icon to open the layer info box.
When you hover over other layers, the "i" icon (as well as the layer row itself) should stay highlighted on the initial layer you clicked.
When you close the info box, the "i" icon that was previously highlighted should become unhighlighted.
On any layer, click the layer tools menu icon (...).
The layer tools menu should open and the ... icon should stay highlighted and visible.

Connects to #43

kdeloach commented 8 years ago

This does fix the bug, but I'm worried that if we continue to make ad-hoc changes to the tree using jQuery, we'll eventually begin to encounter the same sort of weird UI glitches that occurred in the old layer selector.

kdeloach commented 8 years ago

+1 Tested

caseycesari commented 8 years ago

After looking into it more, I was able to unhighlight the "i" icon by updating the state instead of removing the class. See 8abf8a1694e4346fb1e88c56aa515c5133c26e53.

Integrating the layer menu into state updates is a little tricker because of the dynamic nature of the menu. I'm hesitant to leave 2ef741a9788d9be17ffde337ac9990d37afa8206 as is since it only involved removing two lines of code, but I can spend some more time changing how it works if you think it's worth it.

kdeloach commented 8 years ago

I think this is good enough for now. Messing with the layer menu does look tricky.