search

CoastalResilienceNetwork / regional-planning

ArcGIS and WMS map layer plugin for the GeositeFramework
0 stars 2 forks source link

Adjustments for using Esri ArcGIS JS API v4.2 #75

Closed kellyi closed 7 years ago

kellyi commented 7 years ago

Overview

This PR is meant to work in tandem with https://github.com/CoastalResilienceNetwork/GeositeFramework/pull/831. We're creating a new branch of the Geosite Framework which will use the Esri ArcGIS JS API v4.2, and the changes here begin the adjustments necessary for having a plugin work with the framework modifications.

Notes

Many of the changes here entail renaming things to match the new API, or commenting out things which are not yet supported. I've disabled the Draw & Report plugin for now, and I've commented out WMSLayer references, as that type is not yet supported by v4.2.

The last commit here makes a few adjustments to get the plugin to show up properly with the changes made to the corresponding GeositeFramework branch.

Testing

This should be tested in tandem with https://github.com/CoastalResilienceNetwork/GeositeFramework/pull/831, which has testing instructions.

Connects https://github.com/CoastalResilienceNetwork/GeositeFramework/issues/828

kellyi commented 7 years ago

Cool. I updated some of the comments here to match the style suggested for the concurrent GeositeFramework PR. Going to push the additional commits, then merge this one.