CoastalResilienceNetwork / regional-planning

ArcGIS and WMS map layer plugin for the GeositeFramework
0 stars 2 forks source link

Render transparency correctly #84

Closed caseycesari closed 7 years ago

caseycesari commented 7 years ago

A port of https://github.com/CoastalResilienceNetwork/regional-planning/pull/74. Specifically 33746f5fed3a6f28be7b9ecc548b7440c13f3148.

The default image format of png8 would blend transparent images against a solid white background, and render that blended image which would not be actually transparent on the front-end. png32 on the other hand renders transparent images correctly, thus is the preferred image format.

Unfortunately, it needs to be set before every call, and cannot be used during layer initialization. We must be careful of this potentially overloading the server if many layers are visible.

Connects to #83 Connects to #82

Demo

image

Testing

kellyi commented 7 years ago

Not sure if it's related to these changes but it looks like icon_sm.png is missing when I build this branch on my local:

screen shot 2017-03-07 at 2 56 56 pm

mmcfarland commented 7 years ago

I'm pretty sure icon_sm is only used in the "new" framework, this version of the plugin should be aligned with the master branch framework.

caseycesari commented 7 years ago

Yeah, sorry. Forgot to mention that.

caseycesari commented 7 years ago

Thanks