search

CoatiSoftware / vs-sourcetrail

Visual Studio Extension to communicate with Sourcetrail and generate a JSON Compilation Database from a Visual Studio Solution
Apache License 2.0
117 stars 42 forks source link

The extension is not compatible with the new Visual Studio 2019 Preview #48

Closed astrolemonade closed 5 years ago

astrolemonade commented 5 years ago

Hello and thank you for viewing the issue. I have been using Visual Studio 2019 Preview for more than a month and I noticed some improvements in performance and startup time.I want to use SourceTrail with it, but I can't install the extension since is not compatible with the IDE. Can anybody help me solve this ? Can some modifications to the .vsix extension solve the problem or it is another solution ? Thank you !

astrolemonade commented 5 years ago

Any ideas?

mlangkabel commented 5 years ago

H @cata0309, thanks for bringing this up. Can you please try to download and install the following package to your VS2019 installation?

vs-sourcetrail.zip

If that works for you, we will adjust the build file here on the repo and issue a new release :)

astrolemonade commented 5 years ago

image I can't install it, unfortunately

astrolemonade commented 5 years ago

image I think there must pe a 2019 enginewrapper and must be linked to the manifest.json file and changed the version area of the core editor and the IDE itself to cover 16 and above versions of Visual studio IDE. Just some ideas.

astrolemonade commented 5 years ago

I tried to make a copy of the 2017 engine wrapper and decompile it in Jetbrains's IDE dotPeek and modify it to support 2019 version, but no succes.

astrolemonade commented 5 years ago

What do you think @mlangkabel ?

mlangkabel commented 5 years ago

Thanks for testing. I just found out that we missed to extend the accepted version of one prerequisite of the plugin to VS2019.

Please try to run this installer: vs-sourcetrail.zip

If that lets you install the extension, we know that VS2019 compatibility is possible and we need to add VCProjectEngineWrappers for VS2019 to properly implement the core functionality - as you already pointed out :)

astrolemonade commented 5 years ago

It's working on the moment, I will test it some days and if I have any problem with it I will comment on this issue

astrolemonade commented 5 years ago

Thank you

mlangkabel commented 5 years ago

Thanks for testing! So now that the installer is working we need to add those wrappers for VS2019. I will create a branch for that now.

astrolemonade commented 5 years ago

No problem, I love to help

CoolOppo commented 5 years ago

Would love to have this for VS 2019. Currently I'm only keeping VS 2017 installed in case I need to use this extension.

mlangkabel commented 5 years ago

Implemented with merge of pull request #54