search

CobaltFusion / DebugViewPP

DebugView++, collects, views, filters your application logs, and highlights information that is important to you!
Boost Software License 1.0
982 stars 144 forks source link

Font settings not saved when default font in an empty string #330

Closed tmplinshi closed 5 years ago

tmplinshi commented 5 years ago

Hello, thanks for the tool.

I want to increase the font size, but after restart the program, the font size was reset to default. I also tried "Save Configuration..." but I didn't see the font settings in the DebugView++.dbconf file.

janwilmans commented 5 years ago

Hm thanks for reporting :)

On Tue, Aug 14, 2018, 20:28 tmplinshi notifications@github.com wrote:

Hello, thanks for the tool.

I want to increase the font size, but after restart the program, the font size was reset to default. I also tried "Save Configuration..." but I didn't see the font settings in the DebugView++.dbconf file.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/CobaltFusion/DebugViewPP/issues/330, or mute the thread https://github.com/notifications/unsubscribe-auth/AFqJhOAwGmj7X6Jq6C3ffH16M_rkwsskks5uQxbHgaJpZM4V88ml .

janwilmans commented 5 years ago

it does not reproduce here, fonts are saved correctly, can you re-test on the last version? https://github.com/CobaltFusion/DebugViewPP/releases/tag/v1.8.0.17

tmplinshi commented 5 years ago

Ok, I found the reason. It's when no font name were selected, then the font settings won't saved.

janwilmans commented 5 years ago

I cant seem to get into a scenario when no font is selected? I tried removing everything from the registry, but even then still a default font is always selected. What windows version are you on? maybe its a version specific thing?

tmplinshi commented 5 years ago

I'm using Windows 10 x64 (Chinese language), the default font name "宋体" is in Chinese characters, maybe it's because of the font name?

janwilmans commented 5 years ago

Ah, maybe its a character conversion problem, I will look into that. So you do you get into the issue, you just start debugview++, open the font selector and the default selection is then empty?

Greetings,

Jan

On Fri, 17 Aug 2018 at 10:15, tmplinshi notifications@github.com wrote:

I'm using Windows 10 x64 (Chinese language), the default font name "宋体" is in Chinese characters, maybe it's because of the font name?

Jan Wilmans notifications@github.com 于 2018年8月17日周五 下午4:01写道：

I cant seem to get into a scenario when no font is selected? I tried removing everything from the registry, but even then still a default font is always selected. What windows version are you on? maybe its a version specific thing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/CobaltFusion/DebugViewPP/issues/330#issuecomment-413789596 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AEPpxIJN_ss2W4aOednd0PcdZdeaOOGeks5uRnh1gaJpZM4V88ml

.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/CobaltFusion/DebugViewPP/issues/330#issuecomment-413792667, or mute the thread https://github.com/notifications/unsubscribe-auth/AFqJhFyewtQ3318ctaCvZlmLrIzzQqnRks5uRnukgaJpZM4V88ml .

-- Jan

tmplinshi commented 5 years ago

That's correct :)

tmplinshi commented 5 years ago

I have checked the registry, the value of FontName is empty.

janwilmans commented 5 years ago

could you try again on v1.8.0.24 ? I fixed some conversion functions for #328 and I wonder if they also solve this problem?

tmplinshi commented 5 years ago

Thanks, just tried it, but the issue remains. For now I can select a font to solve the issue.

janwilmans commented 5 years ago

I can't reproduce it, but I think this happens because then 'system default' font is read/converted into an empty string. Since it is very easy to work around (just select a font), I'm going to close this issue