CobaltWolf / Bluedog-Design-Bureau

Stockalike parts pack for Kerbal Space Program
https://forum.kerbalspaceprogram.com/index.php?/topic/122020-131mostly-functional-141-bluedog-design-bureau-stockalike-saturn-apollo-and-more-v142-%D0%B0%D1%82%D0%BB%D0%B0%D1%81-1feb2018/
126 stars 144 forks source link

BDSEP-TVO SSTV Camera can't be picked up after deployment #1290

Closed Echo1-1A closed 2 years ago

Echo1-1A commented 2 years ago

When a Kerbal attempts to pick up the part in question after it was deployed, it would remain in place in a non-functional state, while creating a duplicate in the Kerbal's inventory. The non-functional original is no longer anchored on the surface, and can be bumped around by other things. While the duplicate can't be deployed again unless it was put inside another inventory, and then retrived.

Rodg88 commented 2 years ago

Can you post your KSP.log? And you definitely deployed via the icon in the kerbals inv, not with Eva construction?

Echo1-1A commented 2 years ago

Unfortunately, I didn't preserve the log file of the run during which the issue occured. I will try and see if I can recreate the issue, and provide the log file then. And yes, it was deployed via the Kerbal's inventory.

Echo1-1A commented 2 years ago

KSP.log Not sure if this I uploaded it correctly, but here's the log file of my attempt at recreating the issue. Something worth noting is that, unlike the first time, I could not deploy the 'duplicate' in the Kerbal's inventory, even after placing and taking it out of different containers.

Rodg88 commented 2 years ago

Haven’t tested in game yet myself, but from the log I saw you have a fairly old version of KSPCF, might be worth trying again after updating that (and harmony) https://github.com/KSPModdingLibs/KSPCommunityFixes/releases

otherwise, was it happening on a camera that was placed before a recent update to BDB? And did newly placed ones work better? Some experiment definitions have been changed recently, and it’s possible KSP doesn’t handle that well. Another thing that may have done something (but unlikely) is trying to have two cameras connected to one central station.

Echo1-1A commented 2 years ago

I'll be sure to test it again after updating KSPCF. As for BDB version I'm using, it was downloaded 4 days ago, not sure if it's after the change to experiment definitions. Also, my camera was deployed after that, in fact, I opened this issue right after I've encountered the bug.

Rodg88 commented 2 years ago

Found the issue, thanks!

Echo1-1A commented 2 years ago

Glad I could be of help!

Rodg88 commented 2 years ago

@CobaltWolf this was caused by a lack of deployAnimation. It stops breaking if you just set deployAnimationName to the same animation as activeAnimationName, but that causes it to play the full active animation before you pack it up. A quick 'unpack' animation with no movement that can be the deployAnimation instead would work nicely.

CobaltWolf commented 2 years ago

second animation is called "deployFake"