search

CobaltWolf / Bluedog-Design-Bureau

Stockalike parts pack for Kerbal Space Program
https://forum.kerbalspaceprogram.com/index.php?/topic/122020-131mostly-functional-141-bluedog-design-bureau-stockalike-saturn-apollo-and-more-v142-%D0%B0%D1%82%D0%BB%D0%B0%D1%81-1feb2018/
121 stars 144 forks source link

BDBTankType variable for Balloon Tanks missing from Centaur Tanks #1404

Open Pappystein opened 8 months ago

Pappystein commented 8 months ago

So I was looking to create either a part switching config or a whole new part for the Monocoque Saturn S-V Centaur C/E stage, utilizing the ingame assets. During my prototype building based on the Centaur D tank file, I discovered a serious flaw.

Fuel switching was updated by Jso to use Variables a couple of years ago... One of the Variables is bdbTankType if set = Balloon then Balloon tankage mass modifiers are used with the tanks in question... saving about half the mass per unit fuel.

The variable is applied to ALL atlas parts and The Vega Parts... but the Centaur tank parts all appear to be missing it:

The stand-alone variable line is:

bdbTankType = bdbBalloon

If you look on any of the non Atlas V atlas tanks you will find it (same with Vega)

Tank files affected: bluedog_CentaurD_Tank bluedog_CentaurIII_FuelTank bluedog_CentaurT_AdapterTank bluedog_CentaurT_ShortTank bluedog_CentaurT_TankA bluedog_CentaurT_TankB bluedog_CentaurT_TankC bluedog_CentaurT_TankD

Rodg88 commented 3 months ago

Setting this may require re-balancing the mass of the parts too, but I'll have a look

Pappystein commented 3 months ago

Turns out I found a REALLY OLD conversation thread. All Hydrolox tanks are treated as Balloon already. Sorry, I literally discovered this 3 days ago while looking up information to follow up on SUS/Agena2000/Delta IV SUS, and had long forgotten about this post.

When Hydrolox tanks were set up, ONLY Centaur was really on the horizon. This means both the S-IV/S-IVB and S-II-396 tanks are probably UNDER massed. IDK if that is worth diving into or not.

zorg2044 commented 3 months ago

Turns out I found a REALLY OLD conversation thread. All Hydrolox tanks are treated as Balloon already. Sorry, I literally discovered this 3 days ago while looking up information to follow up on SUS/Agena2000/Delta IV SUS, and had long forgotten about this post.

When Hydrolox tanks were set up, ONLY Centaur was really on the horizon. This means both the S-IV/S-IVB and S-II-396 tanks are probably UNDER massed. IDK if that is worth diving into or not.

Im not sure that it is. There is a balloon cryo tank type and a regular cryo tank type defined with different masses. The balloon cryo only seems to be in use on LFO tanks with the flag as part of the additional fuel type switches. But the whole fuel switcher is quite complex and JSO who understands it best isnt around really anymore so we will need to take a close look before changing anything (if needed)