possible part merges

[Rodg88]

engines:

• [x] Able/Ablestar aj10* - check cck/FE - update gimbals
• [x] RL10^ - think each deployable engine needs a unique animation name, so needs one of them to be re-exported
• [x] J-2
• [x] J-2S/J-2A-2? maybe include in main J-2?
• [x] H1 C/D
• [x] Delta AJ10-118F/K/X, maybe TR-201*
• [x] Agena 8096C*
• [ ] Check Agena D secondary engines 8250/8250-B* - check disabling RCS - works but would still need the non-engine variant
• [x] MB60^ - would require either renaming one of the two model's gimbal transform sets, or a supplementary gimbal mu
• [x] RL20 SL/Vac^ - would require either renaming one of the two model's gimbal transform sets, or a supplementary gimbal mu
• [x] GEM 60/XL
• [x] A7

~GEM 40 SRBs - trying to toggle the gimbal module isn't working well, the PAW doesn't update correctly like the H-1. no idea why~

* check hypergol patch ^ update methalox patch

probe parts:

• [ ] mariner star trackers (maybe?)
• [ ] mariner 3/4 cams - investigate science switching, or just science value switching - science switching should work
• [ ] mariner 10 cams
• [ ] pioneer aft adapter - check radiators
• [ ] transit gravity gradient boom - check solar panel switching
• [x] probe rcs set - maybe divide into 1/2/3/4 nozzle parts for less switches.
• [ ] Check OGO solar panels/disabling science modules - works for the most part (module inactive + rename scidef to null), but some of the usual deployment issues combining two deploying modules. Might work better with some DMMSAG tweaks
• [x] surveyor probe cores?
• [x] surveyor antennas, would need mu merging for deploy anims
• [x] Ranger/Mariner bare core

Looks like antenna switching doesn't really work well - even if the module looks like it's disabled, it still will transmit science. Updating the antenna power as well can work around this. Non-animated antennas also can't be switched, seems like the antenna deploy animation is partially why the viking antenna switch works. So any non animated ones (all of the rest) would need dummy animations? Antenna info mods also don't handle the modules changing, like Antenna Helper or CommNet Antennas Info. probably not worth it. ~mariner 2 solar/antenna - needs mu merging mariner 2 tracking solar/antenna - needs mu merging mariner 5 solar/antenna - needs mu merging mariner 8/9 solar/antenna - needs only the antenna .mu viking orbiter solar panels - needs only the antenna .mu - would need extrudedSurface2 to be moved under a new transform which the deploy animation moves instead. Just moving it under hinge2 should work? Deploying the panel while it's disabled currently re-enables it.~

other:

• [x] redstone 300/600 extension tanks
• [x] thor x400/x800 tanks
• [x] thor 360/600 adapter tanks
• [x] able tanks
• [x] LDC structural adapters (maybe?) 3.125 to 1.875 (short/long)/2.5/3.75 - 1.875m is separate due to paint switch
• [x] Titan 1/3 s1 engine shrouds
• [x] Saturn SIVB 500/550 APS
• [x] Gemini ferry RCS
• [x] MOL RCS
• [x] Apollo RCS - maybe divide into 1/2/3/4 nozzle parts for less switches.
• [x] LM Truck RCS
• [x] Saturn SLA bases
• [x] Saturn SLA panels
• [x] Atlas Skirts

[JacobB094]

I wouldn't merge the TR-201. It's more or less completely unrelated to AJ-10 series, being a modified LMDE. If anything, merge it into that.

[Rodg88]

It's another Delta upper stage engine however, and the models gimbal setup is the same, which makes merging much simpler. It's probably either the AJ10 or keeping it separate, the LMDE is quite different in-game in terms of performance, model/size, gimbals, and tech tree placement.

[CobaltWolf]

Don't go too crazy with it. The last thing we want is to make it harder to find things. Try to stick to parts that are basically identical except for a nozzle or antenna, stuff like that.

[JacobB094]

It might be better to keep it separate, then. Although, it would also not be amiss to reinforce the connection to LMDE, it should be together with the late model LMDE in the tech tree. IRL, Delta-P came about specifically because they had a bunch of thrust chambers about the right size and performance for a Delta, and they wanted to fly them off. TR-201 was literally the LMDE modified for fixed thrust, and with a different nozzle extension to improve efficiency in that application.

[zorg2044]

Should probably merge the Atlas A, D and F skirts too... The D skirt was separate because of the animation module and i dunno I felt since A and D were separate why not make F separate too. Wasn't really thinking straight :P

Anyway would be nice if the animation module can be disabled successfully on D.

[JacobB094]

There seems to be something wrong with the AJ-260s in real names mode. I'm getting this error: `[EXC 14:39:30.923] Exception: Could not find matching module B9PartSwitch.ModuleMatcher.FindModule (Part part) (at :0) B9PartSwitch.ModuleModifierInfo+d__10.MoveNext () (at :0) B9PartSwitch.PartSubtype.Setup (B9PartSwitch.ModuleB9PartSwitch parent, System.Boolean displayWarnings) (at :0) UnityEngine.DebugLogHandler:LogException(Exception, Object) ModuleManager.UnityLogHandle.InterceptLogHandler:LogException(Exception, Object) UnityEngine.Debug:LogException(Exception) B9PartSwitch.PartSubtype:Setup(ModuleB9PartSwitch, Boolean) B9PartSwitch.ModuleB9PartSwitch:InitializeSubtypes(Boolean) B9PartSwitch.ModuleB9PartSwitch:GetInfo() PartLoader:CompilePartInfo(AvailablePart, Part)

d__56:PartLoader+d__56.MoveNext_Patch0(d__56) KSPCommunityFixes.Performance.d__62:MoveNext() KSPCommunityFixes.Performance.d__58:MoveNext() UnityEngine.SetupCoroutine:InvokeMoveNext(IEnumerator, IntPtr) ` The gimbal on the inline variant's main nozzle doesn't seem to work.

[JacobB094]

Are we planning on merging GEM-60 and GEM-60XL? It seems like that could be done as a length switch.

[Rodg88]

Those are probably doable yeah. Could possibly merge 46 into the 40 too, but would require new mu files to make an inline 46

[JacobB094]

Well, that wouldn't exactly be a bad thing, though if you really wanted to avoid that, you could make them into one sequence instead - going something like -40, -40 inline, -46. That said, I do like the idea of an inline GEM-46. Maybe it could have a small tapering section on top, so it comes out to the same diameter as -40, despite being a little fatter.

[JacobB094]

Is that possible to switch a fairing base along with the sidewalls? I'm asking because the Agena fairing has a lot of variants, each of which is a distinct part. Most other LVs already have a single fairing base that takes care of most of the options.

If not, we should at least unify the display names (both real and Kerbal), so they all show up in the same place in the part list. Something like Agena Standard Fairing, Agena JPL Fairing, Agena Poppy Fairing and so on.

[JacobB094]

Why was the Vanguard Able tank not integrated with the Thor-Able ones? It's basically identical to the 60 version, only differing visually.

[Rodg88]

Mainly due to able and vanguard assets being in different part folders