search

CobayaSampler / cobaya

Code for Bayesian Analysis
http://cobaya.readthedocs.io/en/latest/
Other
124 stars 124 forks source link

Incorrect results from drag:True #165

Closed cmbant closed 3 years ago

cmbant commented 3 years ago

I think the current dragging algorithm is invalid (returns incorrect results): I think there should be drag_interp_steps+1 in both factors at https://github.com/CobayaSampler/cobaya/blob/master/cobaya/samplers/mcmc/mcmc.py#L496.

Fix along with new test in https://github.com/CobayaSampler/cobaya/pull/163 (other changes also needed for mpi tests to run OK).

cmbant commented 3 years ago

Also, perhaps we should allow drag_interp_steps>=1 rather than drag_interp_steps >=2? (would make test faster if nothing else)

cmbant commented 3 years ago

Now fixed on master