CobayaSampler / cobaya

Code for Bayesian Analysis
http://cobaya.readthedocs.io/en/latest/
Other
126 stars 125 forks source link

Interpolation error creating a delta chi2 = 20 on DESI likelihood #352

Closed vivianmiranda closed 5 months ago

vivianmiranda commented 5 months ago

Hi @cmbant @JesusTorrado

In both CAMB and CLASS (older version of Cobaya - so I have not tested if this problem is absent on new versions). I was getting chi2 ~40 for DESI and horrible predictions on bin z = 1.4

Then I made this change (picture attached)

Screenshot 2024-04-08 at 1 58 25 AM

and chi2 drop to 20.

With the fix (random cosmology - see the z=1.49 prediction and DESI chi2):

Screenshot 2024-04-08 at 2 02 06 AM

Without the fix

Screenshot 2024-04-08 at 2 03 54 AM
cmbant commented 5 months ago

Perhaps this was fixed with https://github.com/CobayaSampler/cobaya/pull/344 - can you check on latest master?

The DESI Y1 likelihood in the current master (from DESI team) returns a chi2 of about 21 on the test point.

vivianmiranda commented 5 months ago

I will check that.

On another note - the cover matrix of Pantheon+ (and dv) looks like a javascript code

https://github.com/CobayaSampler/sn_data/blob/master/PantheonPlus/Pantheon%2BSH0ES_STAT%2BSYS.cov

And I am getting reading errors. Is that the correct file?

vivianmiranda commented 5 months ago

Also DES-Y5 is missing (STAT+SYS.txt)

https://github.com/CobayaSampler/sn_data/tree/master/DESY5

cmbant commented 5 months ago

No it’s not, should be same as

https://github.com/PantheonPlusSH0ES/DataRelease/blob/main/Pantheon%2B_Data/4_DISTANCES_AND_COVAR/Pantheon%2BSH0ES_STAT%2BSYS.cov

Antony

From: Vivian Miranda @.> Sent: Monday, April 8, 2024 7:24 PM To: CobayaSampler/cobaya @.> Cc: Antony Lewis @.>; Mention @.> Subject: Re: [CobayaSampler/cobaya] Interpolation error creating a delta chi2 = 20 on DESI likelihood (Issue #352)

I will check that.

On another note - the cover matrix of Pantheon+ (and dv) looks like a javascript code

https://github.com/CobayaSampler/sn_data/blob/master/PantheonPlus/Pantheon%2BSH0ES_STAT%2BSYS.cov

And I am getting reading errors. Is that the correct file?

— Reply to this email directly, view it on GitHubhttps://github.com/CobayaSampler/cobaya/issues/352#issuecomment-2043284330, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA6GQI7UQEAYPEOY6YUANSDY4LHETAVCNFSM6AAAAABF4BI7IKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTGI4DIMZTGA. You are receiving this because you were mentioned.Message ID: @.***>

cmbant commented 5 months ago

PantheonPlus should be fixed now. (I don't have a test value to add a unit test)

cmbant commented 5 months ago

Also DES Y5 (thanks, looks like an inconsistency in the names in the original repo)

cmbant commented 5 months ago

Is DESI OK for you now on master, can we close?