search

CobbCoding1 / Cano

Text Editor Written In C Using ncurses
Apache License 2.0
63 stars 12 forks source link

Find and Replace feature, Write_Log feature #23

Closed MohammedAlAkashi closed 5 months ago

MohammedAlAkashi commented 5 months ago

2 new features, 1 still isnt done. Write_Log function just takes in a string and writes it down on a file in /logs/log.txt

Find and Replace seems to be able to find the text but it doesnt replace it properly. it replaces some other random text in the editor. i also found a bug, try doing SHIFT + TAB, it will type "a" instead of indenting backwards. I cant seems to figure out the issue with the random changing of text from the Find and Replace. i explained how to use it in the comments.

CobbCoding1 commented 5 months ago

Good stuff, thanks! I will look into why it doesn't work properly, it can be kind of hard to work with the buffer if you aren't familiar with how it's set up. The logging feature is also super handy, and I was just planning on implementing one, so thanks for that. One note though, I prefer pull requests to focus on one thing, so instead of submitting both at the same time, you do one for the logging, and one for the search and replace. It's not a big deal, but it just makes it a bit easier to review, because I know what is for what.

Thanks a ton!