CobbleSword / BurritoSpigot

BurritoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes. while offer extra APIs and support for plugins
Other
51 stars 18 forks source link

Crash on join #17

Open ZethiaZ opened 2 years ago

ZethiaZ commented 2 years ago

When I join the server the following error spams console and I am unable to connect from the server.

I am using debian and jdk 17. The plugins used are listed in the crash log (a /pl query was issued). The deluxehub version has been motified to accept unknown 1.8 server versions and has worked without issue on TacoSpigot and other 1.8 spigots I have used before.

crash.txt

ghost commented 2 years ago

This seems to be caused by netty, a temporary fix is to disable "use-native-transport" in server.properties

ZethiaZ commented 2 years ago

Can confirm turning off use native transport does fix it. Since you seem to know, what does use native transport actually even do?

ghost commented 2 years ago

Can confirm turning off use native transport does fix it. Since you seem to know, what does use native transport actually even do?

generate less garbage, and generally improve performance when compared to the NIO based transport.

HeathLoganCampbell commented 2 years ago

Can confirm turning off use native transport does fix it. Since you seem to know, what does use native transport actually even do?

generate less garbage, and generally improve performance when compared to the NIO based transport.

_wut, that's not true, if that was the case we would all disable it. What native transport does is use the java based networking, while Netty NIO uses special system level calls that can optimize packet sending. as well as bytebuf to use byte arrays on the heap instead off on the stack, which allows netty to produce less garbage, thus less GC time.

It breaks on java 17 because the current version of netty we use in BurritoSpigot doesn't support that java 17_ nvm rip, sorry, I was wrong, sorry about that

ghost commented 2 years ago

Can confirm turning off use native transport does fix it. Since you seem to know, what does use native transport actually even do?

generate less garbage, and generally improve performance when compared to the NIO based transport.

wut, that's not true, if that was the case we would all disable it. What it does is use the java based networking, while NIO uses special system level calls that can optimize packet sending. as well as bytebuf to use byte arrays on the heap instead off on the stack, which allows netty to produce less garbage, thus less GC time.

It breaks on java 17 because the current version of netty we use in BurritoSpigot doesn't support that java 17

Netty says that 😔 i got lied my whole life

HeathLoganCampbell commented 2 years ago

Let me read more about this

HowardZHY commented 2 years ago

crash-2022-01-02_21.54.12-server.txt crash-2022-01-03_12.39.21-server.txt crash-2022-01-03_12.44.51-server.txt crash-2022-01-02_21.02.22-server.txt crash-2022-01-02_21.10.45-server.txt I cannot find more information about crashing

HowardZHY commented 2 years ago

Crashing could happen when someone joined. Plugins can see in these reports.

HowardZHY commented 2 years ago

It seems like server crashes randomly when people join. crash-2022-01-05_18.51.43-server.txt crash-2022-01-05_19.01.55-server.txt crash-2022-01-05_19.37.27-server.txt crash-2022-01-05_22.03.45-server.txt In fact, it crashes 6 times today :(