search

CobbleSword / BurritoSpigot

BurritoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes. while offer extra APIs and support for plugins
Other
53 stars 18 forks source link

Suggest commands /reload and /restart cannot run in command block #20

Open HowardZHY opened 2 years ago

HowardZHY commented 2 years ago

Is your feature request related to a problem? Please describe. This could cause security problems. Wurst and other hacked clients could get written cmd-blocks with /rl and /restart and activate with redstone.

Describe the solution you'd like /reload and /restart cannot run in cmd-block anymore.

Describe alternatives you've considered null

Additional context null

CyberFlameGO commented 2 years ago

This feature request can most likely be implemented via the API, so in my opinion it’s irrelevant

sadcenter commented 2 years ago

This feature request can most likely be implemented via the API, so in my opinion it’s irrelevant

Exactly, ServerCommandEvent is a cancelable event (BlockCommandSender is the implementation of command block sender I think)

HowardZHY commented 2 years ago

I reported this to paper issues and they dont even think this is a problem

CyberFlameGO commented 2 years ago

Exactly, it isn't

HowardZHY commented 2 years ago

cmd-block's permit level is 2 , isnt it /restart permit level should be 4 , like /stop

CyberFlameGO commented 2 years ago

Oh really? I thought command blocks having a lower operator level was only on later versions. Regarding your point though, I don't think /restart and /reload care what operator level the user has, unlike with /stop. It's a valid point but I don't see anyone encountering issues regarding it because the circumstances are too unique, and even if it's encountered a plugin can mitigate it

HowardZHY commented 2 years ago

https://minecraft.fandom.com/wiki/Permission_level if /restart can even run with permit level 1 OP (change in ops.json) , that MUST be an PROBLEM

crafter23456 commented 2 years ago

https://github.com/PaperMC/Paper/issues/7567 no comment besides you can only report issues there to their latest version... disable commandblocks in your server.properties and youre fine. dont work with operators, work with permissions.