CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.
GNU General Public License v3.0
237 stars 87 forks source link

add disable fall animation #203

Closed BakuQ closed 2 years ago

BakuQ commented 2 years ago

Added ability to disable falling sand, gravel, anvil etc. It means the server will not lag when a large number of items drops and it will improve client-side fps

CyberFlameGO commented 2 years ago

https://github.com/CobbleSword/NachoSpigot/blob/464f1c162f40122b468cf422c869ffe84d144efb/NachoSpigot-Server/src/main/java/me/elier/nachospigot/config/NachoWorldConfig.java#L92-L100

Edit (Lucas): updated link

sadcenter commented 2 years ago

@CyberFlameGO yea, there is an option to disable entire blocks physics, but not the falling animation. I think the author means to add an option to disable falling blocks animation

https://user-images.githubusercontent.com/55924469/138169040-2b2c00e9-71ff-4b57-9cbf-1fba6d81eb05.mp4

CyberFlameGO commented 2 years ago

Ah right, well it's just a few FallingSand entities and I don't really see the point of it, but if anyone wants to contribute the requested functionality, you're more than welcome to

sadcenter commented 2 years ago

I think there IS a point. if you combine TNT with a lot of sand - it can lag the entire server. Some polish servers had a problem with that for a moment. https://youtu.be/u9agMUXHY1Q?t=541

CyberFlameGO commented 2 years ago

Alright, got a link to a repository that implements it?

sadcenter commented 2 years ago

Unfortunately, nope. I only have a simple plugin that disables it. https://www.dropbox.com/s/qop3p16sitja7qz/NFB.jar?dl=0

BakuQ commented 2 years ago

@CyberFlameGO yea, there is an option to disable entire blocks physics, but not the falling animation. I think the author means to add an option to disable falling blocks animation

2021-10-20.22-44-08.mp4

that's what I mean. This would improve server performance

CyberFlameGO commented 2 years ago

Unfortunately, nope. I only have a simple plugin that disables it.

In that case, it's probably out of scope unless you wanna contribute it, because a plugin can do it just as well as we can natively.

BakuQ commented 2 years ago

Unfortunately, nope. I only have a simple plugin that disables it.

In that case, it's probably out of scope unless you wanna contribute it, because a plugin can do it just as well as we can natively.

so it will not be?

CyberFlameGO commented 2 years ago

I mean I can try, but no guarantees

BakuQ commented 2 years ago

Mam na myśli, że mogę spróbować, ale bez gwarancji

Okay, I will be very grateful to have a good day

CyberFlameGO commented 2 years ago

Can someone test the difference between disablePhysicsPlace and disablePhysicsUpdate and let me know? Also, do either of those options provide the functionality you're asking for? (I'd check myself but I don't have Minecraft on the laptop I'm using right now)

BakuQ commented 2 years ago

Can someone test the difference between disablePhysicsPlace and disablePhysicsUpdate and let me know? Also, do either of those options provide the functionality you're asking for? (I'd check myself but I don't have Minecraft on the laptop I'm using right now)

I'm writing this from the phone so I don't have how: /

BakuQ commented 2 years ago

Can someone test the difference between disablePhysicsPlace and disablePhysicsUpdate and let me know? Also, do either of those options provide the functionality you're asking for? (I'd check myself but I don't have Minecraft on the laptop I'm using right now)

Overall, I'm delighted with your release, I've already tested a lot of these spigot forks (AtomSpigot, imanity spigot) and yours is the best optimized

sadcenter commented 2 years ago

Can someone test the difference between disablePhysicsPlace and disablePhysicsUpdate and let me know? Also, do either of those options provide the functionality you're asking for? (I'd check myself but I don't have Minecraft on the laptop I'm using right now)

sure, disablePhysicsUpdate is used when other blocks want to update themselves because, for example, someone broke 1 sand in a sand column disablePhysicsPlace when a server wants to update placed block position because of physics. And, These options aren't providing what the author needs, cause he wants physics, but not its animations.

BakuQ commented 2 years ago

@CyberFlameGO tak, istnieje możliwość wyłączenia fizyki całych bloków, ale nie animacji spadania. Myślę, że autorowi chodzi o dodanie opcji wyłączenia animacji spadających klocków

2021-10-20.22-44-08.mp4

as in the movie, there is block physics but no animation

tomasalves8 commented 2 years ago

I've got it working, I'll make a pr soon.

https://user-images.githubusercontent.com/15659074/141447366-eb9985c4-8942-46a0-b342-9ba52bd385e0.mp4