Closed ghost closed 2 years ago
Is this PR done? (still seeing commits after ready for review) If so, I'll review it :)
Is this PR done? (still seeing commits after ready for review) If so, I'll review it :)
I'm working on some more optimizations, I'll let you know when it's ready for review.
Ready for review! @Lucaskyy
I understand that you created an empty class for PaperSpigot's old config but I don't understand the reasoning for refactoring to the new Paper package; 1.8.8 is PaperSpigot not Paper. Is there any benefit to renaming?
I understand that you created an empty class for PaperSpigot's old config but I don't understand the reasoning for refactoring to the new Paper package; 1.8.8 is PaperSpigot not Paper. Is there any benefit to renaming?
I updated the API package so that plugins using that API will work and decided to also update the server package.
My understanding is that plugins would check for the version first before using the Paper API, so the change would be ineffective, but if this is proving useful for someone then fair enough
If there are no further comments/reviews I'll merge this PR this afternoon.
Shouldn't the movement listeners at least just be removed? I see no use in them and they might make performance worse.
Shouldn't the movement listeners at least just be removed? I see no use in them and they might make performance worse.
Larger server use it instead of PlayerMoveEvent
Then what is the point if we're using both?
It generally gets fired a lot less than packet listeners and simpler to use
Since this PR also fixes a bug with HolographicDisplays I'm going to merge this now. If there's still anything that needs changing, we'll figure out soon enough.
Big thanks Elierrr for this PR! :)
Description
Adds some small optimizations, added taco.yml and nacho.yml to timings, moves Paper's code to their new package, adds some command configs, and removes some unneeded code.
Checklist: