Closed Tofpu closed 2 years ago
I checked and it does not unfortunately. do you want me to include the fix here?
EDIT: In the meantime, I have looked into it and I think I got it working? I tested it and the sounds is back as usual.
Awaiting for permission to push the changes here (although I'd feel like a separate pr would be suited better, up to you)
Awaiting for permission to push the changes here (although I'd feel like a separate pr would be suited better, up to you)
It would probably be better to put in another PR. I'll test both when I can.
@Tofpu A separate PR would be better yes :)
@Tofpu A separate PR would be better yes :)
Awaiting for permission to push the changes here (although I'd feel like a separate pr would be suited better, up to you)
It would probably be better to put in another PR. I'll test both when I can.
Got it! You can view the PR at #273
Tested and works as expected!
Thanks, Tofpu for this PR! :)
Description
Please provide a detailed description of the changes you have made.
World#spawnEntity
method, it throwed anNullPointerException
exception. I solved it by adding a few null checks to the EntityProjectile class and sat the position rotation parameters to 0 when said entity is null (though it'd be better than ignoring it entirely)How has this been tested?
How have you tested the changes you have made?
Checklist: