CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.
GNU General Public License v3.0
237 stars 87 forks source link

Ender Pearl Spawn Patch #271

Closed Tofpu closed 2 years ago

Tofpu commented 2 years ago

Description

Please provide a detailed description of the changes you have made.

How has this been tested?

How have you tested the changes you have made?

Checklist:

Tofpu commented 2 years ago

I checked and it does not unfortunately. do you want me to include the fix here?


EDIT: In the meantime, I have looked into it and I think I got it working? I tested it and the sounds is back as usual.

Awaiting for permission to push the changes here (although I'd feel like a separate pr would be suited better, up to you)

ghost commented 2 years ago

Awaiting for permission to push the changes here (although I'd feel like a separate pr would be suited better, up to you)

It would probably be better to put in another PR. I'll test both when I can.

Sculas commented 2 years ago

@Tofpu A separate PR would be better yes :)

Tofpu commented 2 years ago

@Tofpu A separate PR would be better yes :)

Awaiting for permission to push the changes here (although I'd feel like a separate pr would be suited better, up to you)

It would probably be better to put in another PR. I'll test both when I can.

Got it! You can view the PR at #273

ghost commented 2 years ago

Tested and works as expected!

Sculas commented 2 years ago

Thanks, Tofpu for this PR! :)