CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.
GNU General Public License v3.0
237 stars 87 forks source link

Arrow Patch #273

Closed Tofpu closed 2 years ago

Tofpu commented 2 years ago

Description

Please provide a detailed description of the changes you have made.

Fixes/Adds # (issue)

How has this been tested?

How have you tested the changes you have made?

Checklist:

ghost commented 2 years ago

Still receiving the error when the arrow hits the ground player instead of the player ground, you'll have to do the same for line 297.

Tofpu commented 2 years ago

Still receiving the error when the arrow hits the ground instead of a player, you'll have to do the same for line 297.

Got it! Could you by any chance tell me what you did to get that error?

ghost commented 2 years ago

> when the arrow hits the ground instead of a player, When the arrow hits a player.

Tofpu commented 2 years ago

~> when the arrow hits the ground instead of a player,~ When the arrow hits a player.

Aha, that edit makes sense now. I appreciate the pointers!

ghost commented 2 years ago

When it hits a player there is no error in console however there still is no sound effect.

Tofpu commented 2 years ago

When it hits a player there is no error in console however there still is no sound effect.

Hmm, I thought that was to be intended lol, anyway I checked the code further and it seems like the d, e and f values are not being updated, since an entity was involved.

I'm not very familiar with the server's codebase but I'm thinking providing the involved entity would do it. I'll test the theory in a few moments

Edit: That fixed it, awesome!

Sculas commented 2 years ago

Thanks, Tofpu for this PR! :)