Fix #204

[ghost]

Description

Please provide a detailed description of the changes you have made.

Fixes/Adds # (issue)

How has this been tested?

How have you tested the changes you have made?

Additional Comments

Provide any additional information regarding this pull request.

Checklist:

• [x] I have reviewed my code thoroughly.
• [x] I have tested my code.
• [x] My changes generate no new warnings

[andreasdc]

I already have this in my code.

[ghost]

I already have this in my code.

Then you broke something because this patch prevents the physics update when BlockPlaceEvent is cancelled

[andreasdc]

I already have this in my code.

Then you broke something because this patch prevents the physics update when BlockPlaceEvent is cancelled

I doubt so, probably, but you can test it by yourself.

[andreasdc]

I already have this in my code.

Then you broke something because this patch prevents the physics update when BlockPlaceEvent is cancelled

Placing blocks - yes, placing redstone dust - not. Probably something with PandaRedstoneWire.

[ghost]

I already have this in my code.

Then you broke something because this patch prevents the physics update when BlockPlaceEvent is cancelled

Placing blocks - yes, placing redstone dust - not. Probably something with PandaRedstoneWire.

Based on your logic, redstone dust isn't a block?

[Sculas]

Thank you for this PR! :)

[andreasdc]

I already have this in my code.

Then you broke something because this patch prevents the physics update when BlockPlaceEvent is cancelled

Placing blocks - yes, placing redstone dust - not. Probably something with PandaRedstoneWire.

Based on your logic, redstone dust isn't a block?

Test and then say something. Simple debug when placing redstone dust.

[ghost]

I already have this in my code.

Then you broke something because this patch prevents the physics update when BlockPlaceEvent is cancelled

Placing blocks - yes, placing redstone dust - not. Probably something with PandaRedstoneWire.

Based on your logic, redstone dust isn't a block?

Test and then say something. Simple debug when placing redstone dust.

Do it yourself

Your issue was titled with block place event cancelled calls a physics update, i fixed it.

[andreasdc]

.

When placing redstone dust.

[andreasdc]

I already have this in my code.

Then you broke something because this patch prevents the physics update when BlockPlaceEvent is cancelled

Placing blocks - yes, placing redstone dust - not. Probably something with PandaRedstoneWire.

I already did it.

[ghost]

I already have this in my code.

Then you broke something because this patch prevents the physics update when BlockPlaceEvent is cancelled

Placing blocks - yes, placing redstone dust - not. Probably something with PandaRedstoneWire.

I already did it.

Then fix your own issue since you already did a debug stage, i already fixed the titled issue

[andreasdc]

I already have this in my code.

Then you broke something because this patch prevents the physics update when BlockPlaceEvent is cancelled

Placing blocks - yes, placing redstone dust - not. Probably something with PandaRedstoneWire.

I already did it.

Then fix your own issue since you already did a debug stage, i already fixed the titled issue

Titled, but not described. Don't mark it as a fix for the issue then.

[ghost]

I already have this in my code.

Then you broke something because this patch prevents the physics update when BlockPlaceEvent is cancelled

Placing blocks - yes, placing redstone dust - not. Probably something with PandaRedstoneWire.

I already did it.

Then fix your own issue since you already did a debug stage, i already fixed the titled issue

Titled, but not described. Don't mark it as a fix for the issue then.

Your plugin is wrong made because you need to cancel the BlockRedstoneEvent, i fixed your titled issue, if you do strange things in a plugin or your fork is not my problem

[andreasdc]

I already have this in my code.

Then you broke something because this patch prevents the physics update when BlockPlaceEvent is cancelled

Placing blocks - yes, placing redstone dust - not. Probably something with PandaRedstoneWire.

I already did it.

Then fix your own issue since you already did a debug stage, i already fixed the titled issue

Titled, but not described. Don't mark it as a fix for the issue then.

Your plugin is wrong made because you need to cancel the BlockRedstoneEvent, i fixed your titled issue, if you do strange things in a plugin or your fork is not my problem

Shouldn't cancelled BlockPlaceEvent stop BlockRedstoneEvent?

[ghost]

I already have this in my code.

Then you broke something because this patch prevents the physics update when BlockPlaceEvent is cancelled

Placing blocks - yes, placing redstone dust - not. Probably something with PandaRedstoneWire.

I already did it.

Then fix your own issue since you already did a debug stage, i already fixed the titled issue

Titled, but not described. Don't mark it as a fix for the issue then.

Your plugin is wrong made because you need to cancel the BlockRedstoneEvent, i fixed your titled issue, if you do strange things in a plugin or your fork is not my problem

Shouldn't cancelled BlockPlaceEvent stop BlockRedstoneEvent?

Why a event should cancel another event

[andreasdc]

Why would you pass it to redstone even when block place is cancelled?

[ghost]

Why would you pass it to redstone even when block place is cancelled?

Ask to Mojang & CraftBukkit

[andreasdc]

t

Here we are on NachoSpigot, already correcting Mojang & CraftBukkit's code.

[Sculas]

Remind you; this is vanilla behavior! So even if we changed this, this could break plugins!

[andreasdc]

sad violin music

[andreasdc]

Remind you; this is vanilla behavior! So even if we changed this, this could break plugins!

But plugin based on broken behaviour right? 🥇