CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.
GNU General Public License v3.0
237 stars 87 forks source link

Remove explosion-protected-regions (broken IonSpigot patch) #276

Closed ghost closed 2 years ago

ghost commented 2 years ago

Description

Removes the configuration option "explosion-proteccted-regions"

Fixes #230 Fixes #302 Closes #303

Additional Comments

I'm not exactly sure what this is for however it doesn't seem to be needed.

Checklist:

Sculas commented 2 years ago

I assume it's for things such as spawn protection? So it allows you to blow up chunks that are spawn protected.

CyberFlameGO commented 2 years ago

Y’know you don’t need to always force-push everything, it’s only useful when you’re squashing a few commits (3+) that are just edits to the same change, or removing private info.

ghost commented 2 years ago

Y’know you don’t need to always force-push everything, it’s only useful when you’re squashing a few commits (3+) that are just edits to the same change, or removing private info.

I prefer having everything in one commit instead of multiple, and also removing private info wouldn't work since you can still view older commits in GitHub.

CyberFlameGO commented 2 years ago

Fair enough, but in my opinion it’s best to have a feature per commit so if people need to revert something it doesn’t revert useful changes. I forgot that PRs track commits though; I was thinking of repos where you can remove private info via force-push

sadcenter commented 2 years ago

I had the same thought in my mind when I was making the #234 patch. I thought I just don't understand why is it here and should leave it.

Sculas commented 2 years ago

If there are no further comments/reviews I'll merge this PR this afternoon.

Sculas commented 2 years ago

I see there are conflicts, could you look into it @Elierrr ?

ghost commented 2 years ago

I see there are conflicts, could you look into it @Elierrr ?

Fixed the conflicts.

Sculas commented 2 years ago

Thought of that ^ when checking the code. I edited it from GitHub nor did I test it, but I think it shouldn't cause any problems.

Sculas commented 2 years ago

Anyway, I'm going to merge this once the build succeeds. Thank you @Elierrr for this PR! :)

Sculas commented 2 years ago

Oops, gotta fix compile errors hehe.