Closed ghost closed 2 years ago
I assume it's for things such as spawn protection? So it allows you to blow up chunks that are spawn protected.
Y’know you don’t need to always force-push everything, it’s only useful when you’re squashing a few commits (3+) that are just edits to the same change, or removing private info.
Y’know you don’t need to always force-push everything, it’s only useful when you’re squashing a few commits (3+) that are just edits to the same change, or removing private info.
I prefer having everything in one commit instead of multiple, and also removing private info wouldn't work since you can still view older commits in GitHub.
Fair enough, but in my opinion it’s best to have a feature per commit so if people need to revert something it doesn’t revert useful changes. I forgot that PRs track commits though; I was thinking of repos where you can remove private info via force-push
I had the same thought in my mind when I was making the #234 patch. I thought I just don't understand why is it here and should leave it.
If there are no further comments/reviews I'll merge this PR this afternoon.
I see there are conflicts, could you look into it @Elierrr ?
I see there are conflicts, could you look into it @Elierrr ?
Fixed the conflicts.
Thought of that ^ when checking the code. I edited it from GitHub nor did I test it, but I think it shouldn't cause any problems.
Anyway, I'm going to merge this once the build succeeds. Thank you @Elierrr for this PR! :)
Oops, gotta fix compile errors hehe.
Description
Removes the configuration option "explosion-proteccted-regions"
Fixes #230 Fixes #302 Closes #303
Additional Comments
I'm not exactly sure what this is for however it doesn't seem to be needed.
Checklist: