Double block change packet

CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.

GNU General Public License v3.0

237 stars 87 forks source link

Double block change packet #279

Closed andreasdc closed 2 years ago

andreasdc commented 2 years ago

Describe the feature

After placing water there are 2 block change packets coming from PlayerChunkMap. Is it the right behaviour? Maybe you could investigate to see if that should happen? I don't know why https://github.com/CobbleSword/NachoSpigot/issues/278 was closed, but that's not a joke and this causes visual (or other) bugs, while impacting performance. If I'm wrong please tell me.

Technical implementation

No response

Other

No response

Agreements

[X] You have confirmed that this feature does not yet exist in the latest version of NachoSpigot.
[X] You have confirmed that there aren’t any issues open regarding this feature.

andreasdc commented 2 years ago

https://github.com/CobbleSword/NachoSpigot/issues/277#issuecomment-987052695 Don't treat people like gods, from a quick look to Paper 1.17 I don't see similar block updates. Also, "no one has ever done anything about it" - that doesn't mean it doesn't need correction or enhancement would not make it better.

I won't even bring up the biggest mistakes of Mojang/Spigot/Paper devs here.

andreasdc commented 2 years ago

It's messed up, but has some kind of logic in it. If you want you can close it, but I think it's more or less ok. There is still flickering bug when placing the water, but I don't know where's it's coming from.

Sculas commented 2 years ago

It wasn't that your issue was a joke, it's about the fact that I lock the issue since it's to heated and then you just create another issue like nothing?

andreasdc commented 2 years ago

I don't even want to reply to this

Sculas commented 2 years ago

Sigh.. be my guest then.