CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.

GNU General Public License v3.0

237 stars 87 forks source link

Actually fix logger issues #286

Closed Sneakometer closed 2 years ago

Sneakometer commented 2 years ago

Add proper log4j-slf4j18-impl aswell as slf4j api to fix compatibility problems with Luckperms & other plugins. Fixes https://github.com/CobbleSword/NachoSpigot/issues/285 Tested with a bunch of plugins, including latest Luckperms.

Checklist:

[X] I have reviewed my code thoroughly.
[X] I have tested my code.
[X] My changes generate no new warnings

ghost commented 2 years ago

Wouldn't it be better to just use #284 and revert https://github.com/CobbleSword/NachoSpigot/commit/5e428c973f4083a06dc519d5d9568597f592794

Sneakometer commented 2 years ago

Wouldn't it be better to just use #284 and revert 5e428c9

Well, being stuck with outdated dependencies should be avoided if you ask me.

ghost commented 2 years ago

That makes sense.

Sculas commented 2 years ago

Thanks for fixing it!