search

CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.
GNU General Public License v3.0
237 stars 87 forks source link

Fix the tnt issue. blocks were not breaking #303

Closed abhithedev200 closed 2 years ago

abhithedev200 commented 2 years ago

Description

Please provide a detailed description of the changes you have made. removed a check from explosions

Fixes/Adds # (issue) fixes issue #302

How has this been tested?

I got the issue reporter to test this.

How have you tested the changes you have made? yep

Additional Comments

Provide any additional information regarding this pull request. this pr should fix the issue for explosions not breaking blocks

ghost commented 2 years ago

Why we can't just drop the Ion patch completely? since is broken

abhithedev200 commented 2 years ago

Why we can't just drop the Ion patch completely? since is broken

its not needed tbh. because i have fixed the blocks issue and there is no further issue with lon spigot patch until now lol

ghost commented 2 years ago

Why we can't just drop the Ion patch completely? since is broken

its not needed tbh. because i have fixed the blocks issue and there is no further issue with lon spigot patch until now lol

The IonSpigot patch also causes #230

abhithedev200 commented 2 years ago

Why we can't just drop the Ion patch completely? since is broken

its not needed tbh. because i have fixed the blocks issue and there is no further issue with lon spigot patch until now lol

The IonSpigot patch also causes #230

a pr containing fix is already merged right? (https://github.com/CobbleSword/NachoSpigot/pull/234)

ghost commented 2 years ago

That fix completely broke explosions and was reverted in #268

Sculas commented 2 years ago

Thanks for the PR, but #276 supersedes this. So I'm going to close this one in favor of #276 Thanks anyway!