CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.

GNU General Public License v3.0

237 stars 87 forks source link

Directly rename methods instead of using OBFHELPERs and reobfuscate them #308

Closed ghost closed 2 years ago

ghost commented 2 years ago

Completely reobfuscates all OBFHELPERs and obfuscates ProtocolLib's shim to work with ProtocolSupport using SpecialSource

Fixes #301

Additional comments

This uses SpecialSource's maven plugin to reobfuscate all OBFHELPERs.

Sculas commented 2 years ago

Thanks for this PR! Have you tested this to make sure the server compiles and runs correctly? :)

ghost commented 2 years ago

Tested and works fine, I'm currently comparing the decompiled NachoSpigot and decompiled version of this PR to make sure I didn't miss any OBFHELPERs that I didn't add to reobf-mappings.csrg.

ghost commented 2 years ago

Good to go, once this compiles you can merge this! @Lucaskyy

Sculas commented 2 years ago

Thanks for this PR! :)