1337 nbt hax

[Memexurer]

fixes windowclick book exploits idk if it will break anything, i tested it and it worked somehow

[ghost]

You said it yourself 'idk if it will break anything', before opening these types of PR you should do testing

[HeathLoganCampbell]

Could you explain how adding a hash helps?

[Memexurer]

because reading whole Item can crash the server if someone sents an item with nbt exploits

[HeathLoganCampbell]

because reading whole Item can crash the server if someone sents an item with nbt exploits

Doesn't the hash have to read the item too tho? also what's the benchmarks of this change?

[Memexurer]

Benchmark                         Mode  Cnt       Score   Error   Units
NormalItemBenczor.compareHash    thrpt    2   10618,709          ops/ms
NormalItemBenczor.compareNormal  thrpt    2  580908,900          ops/ms
NormalItemBenczor.compareHash       ss    2       1,083           ms/op
NormalItemBenczor.compareNormal     ss    2       0,022           ms/op

nvm guys its too bad

[HeathLoganCampbell]

Nice job @Memexurer, putting ego aside and looking at the numbers

[Memexurer]

btw i broke the benchmarks somehow, its 0,2ms/op but its still bad

[Memexurer]

but at least it fixes nbt exploits 😭😭😭