CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.
GNU General Public License v3.0
237 stars 86 forks source link

Update guava to latest #322

Closed Sneakometer closed 2 years ago

Sneakometer commented 2 years ago

Describe the feature

Update all google libraries to it's latest version, currently guava 31.0.1 and gson 2.8.9 to achieve higher security, allow plugins to use new libary features and better performance.

Technical implementation

Update dependencies in pom.yml and fix compilation errors in

Other

This might break compatibility with rare plugins that deeply interact with nms. This should be properly tested before publishing to the official Nacho builds.

Agreements

ghost commented 2 years ago
  • CraftServer
  • BaseBlockPosotion
  • BlockStateList
  • BlockState
  • PacketPlayOUtPlayerInfo
  • TripwireHook
  • and EntitySlice

It definitely isn’t just those classes, there are other classes that use guava/gson that aren’t imported because we don’t make changes to them.