CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.
GNU General Public License v3.0
237 stars 86 forks source link

Blank lines between some messages #327

Closed DrakMC closed 2 years ago

DrakMC commented 2 years ago

Observed Behavior

I noticed that there are blank lines in the log between some of the messages. For example, when someone writes something in chat.

Expected Behavior

Blank lines should not be displayed.

Steps To Reproduce

  1. Turn on the server with NachoSpigot
  2. Send something in chat
  3. There is a space before the messages in the log

Plugin List

No response

Server Version

[12:18:21 INFO]: This server is running NachoSpigot version git-NachoSpigot-"c901193" (MC: 1.8.8) (Implementing API version 1.8.8-R0.2-SNAPSHOT) You are running the latest version

Other

No response

Agreements

ghost commented 2 years ago

I cannot reproduce this. This is most likely an issue with your console.

DrakMC commented 2 years ago

It happens to me. I'm using pterodactyl panel. It's not caused by the panel because I have blank lines in log file as well.

My log file: https://pastebin.com/raw/QXQDjbkb Panel: https://i.imgur.com/B5nvUVM.png In-game: https://i.imgur.com/p96K7nH.png

DrakMC commented 2 years ago

I updated it to the newest version and it still doesn't work.

crafter23456 commented 2 years ago

Actually thats caused by any java version above 8.

sadcenter commented 2 years ago

well, it doesn't happen on my server, which is also on the pterodactyl panel I'm using ghcr.io/pterodactyl/yolks:java_17 (java 17)

DrakMC commented 2 years ago

I'm using the same image and the problem persists.

crafter23456 commented 2 years ago

I'm using the same image and the problem persists.

Try with Java 8 for testing purpose only. with java 8 i hadnt the problem but with java 11 and up.

crafter23456 commented 2 years ago

I'm using the same image and the problem persists.

Okay, with Java 11 the problem isnt there. I switched to Java 14 and then it happens. My bad memories. I tracked your problem down, that LOGGER.info doesnt write empty lines beneath, only System.out.println(). Yeah for nachospigot we can make a dump way to change the new few (guess 4) System.out.println to LOGGER.info but that isnt purposeful because then all plugins still writes empty lines. So the problem needs to be taken on the roots, System.out.println.

ghost commented 2 years ago

Just change the sysout calls to Logger calls

crafter23456 commented 2 years ago

yeah i make a PR later, almost finished

HowardZHY commented 2 years ago

Burrito also have this on console ?