CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.
GNU General Public License v3.0
237 stars 86 forks source link

Implement starlight #334

Closed sadcenter closed 2 years ago

sadcenter commented 2 years ago

Describe the feature

Implement https://github.com/PaperMC/Starlight light system

Technical implementation

https://github.com/PaperMC/Paper/blob/master/patches/server/0807-Rewrite-the-light-engine.patch https://github.com/PaperMC/Paper/blob/master/patches/server/0808-Always-parse-protochunk-light-sources-unless-it-is-m.patch Here's how the author of starlight did this

Other

I know it's kinda difficult to implement starlight on 1.8.8 but the performance is worth it. I don't think there is a even single fork that has patched it.

Agreements

caoli5288 commented 2 years ago

WTF a 5000+ lines patch?!

sadcenter commented 2 years ago

Most of the patch is just https://github.com/PaperMC/Starlight source code, which you can download

HeathLoganCampbell commented 2 years ago

I don't believe this patch applies to 1.8 due to the world format being different

ghost commented 2 years ago

I don't believe this patch applies to 1.8 due to the world format being different

(also the light engine in 1.16 is a lot of interfaces & abstract classes)

MWHunter commented 2 years ago

Starlight's algorithms are more efficient than 1.8's design, but 1.8 has a much cleaner light engine than 1.14's mess so the difference might not be worth the effort.

sadcenter commented 2 years ago

oh, okay then. My friend told me that the result will be worth it so I opened it