CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.
GNU General Public License v3.0
237 stars 86 forks source link

Use-improved-hitreg doesnt let players fight McDuels bots #350

Closed refractored closed 2 years ago

refractored commented 2 years ago

Observed Behavior

When I enable use-improved-hitreg I cannot damage the bots in McDuels

Expected Behavior

when use-improved-hitreg is enabled, it still lets players fight the bots

Steps To Reproduce

Enable use-improved-hitreg, Duel a bot in mcduels

Plugin List

Plugins (31): AdvancedReplay, AntiCheatReplay, BlockParticles, BungeeGuard, Citizens, CommandNPC, DiscordSRV, Essentials, EssentialsChat, EssentialsSpawn, GadgetsMenu, HolographicDisplays, LaunchPads, LiteBans, LuckPerms, McDuels, Multiverse-Core, MyCommand, PlaceholderAPI, Plan, ProtocolLib, ServerUtils, Spartan, TAB, UltimateAutoRestart, Vault, ViaVersion, VoidGen, WorldEdit, WorldGuard and WorldGuardExtraFlags

Server Version

This server is running NachoSpigot version git-NachoSpigot-"9d51ce2" (MC: 1.8.8) (Implementing API version 1.8.8-R0.2-SNAPSHOT)

Other

I was on 1.18 while testing this, im not sure if its limited to that version or what. It happens on 1.8 too

Agreements

refractored commented 2 years ago

use-improved-hitreg on: https://discordapp.com/channels/730447580580020264/732023562893787228/942977489318318101 use-improved-hitreg off: https://discordapp.com/channels/730447580580020264/732023562893787228/942978383736868935

Sculas commented 2 years ago

Does #349 potentially fix this? @notdap do you possibly know what's going on here?

I don't have time to debug this right now, so I hope someone else could.

ghost commented 2 years ago

349 definitely does not fix this. Most likely the lag compensator thinks the bots are players and doesn’t handle them correctly