CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.
GNU General Public License v3.0
237 stars 86 forks source link

improve lag compensated hitreg #351

Closed wuangg closed 2 years ago

wuangg commented 2 years ago

Description

Improves lag compensated hit registration, to make sure it is compatible with modification from Bukkit event calls when registering movement.

How has this been tested?

This PR should be tested more properly, even though #350 has been fixed by testing with latest version of Citizens2. I'm not sure if it should work with other plugins use Citizens2 as dependency.

Checklist:

Sculas commented 2 years ago

Thanks a lot for this PR! Also, thanks @Elierrr for the ping :)

I'll merge this for now (so we can get a CI build) and then ask @refractored or someone else in the Discord to test it out, as I'm currently not available to help out on this.