CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.
GNU General Public License v3.0
237 stars 86 forks source link

Weird disconnect error with authlib-injector #353

Open HowardZHY opened 2 years ago

HowardZHY commented 2 years ago

Observed Behavior

Same issue https://github.com/yushijinhun/authlib-injector/issues/147(Chinese) When I tried to use authlib-injector on Nacho , my 1.8.9 client had a bad packet id {weird number like xxxxx or -xxxxxxxx} disconnect and there's no error log , only [12:18:48] [LoginProcessingThread/INFO]: Disconnecting com.mojang.authlib.GameProfile@b1fdcdaa[id=,name=HowardZHY,properties={},legacy=false] (/127.0.0.1:50505): Error occured while logging in [12:18:48] [Server thread/INFO]: com.mojang.authlib.GameProfile@b1fdcdaa[id=,name=HowardZHY,properties={},legacy=false] (/127.0.0.1:50505) lost connection: Error occured while logging in [12:18:55] [LoginProcessingThread/INFO]: Disconnecting com.mojang.authlib.GameProfile@b1fdcdaa[id=,name=HowardZHY,properties={},legacy=false] (/127.0.0.1:50522): Error occured while logging in [12:18:55] [Server thread/INFO]: com.mojang.authlib.GameProfile@b1fdcdaa[id=,name=HowardZHY,properties={},legacy=false] (/127.0.0.1:50522) lost connection: Error occured while logging in when everytime I tried to log in.

Expected Behavior

Authlib-injector works on Burrito , it should works on Nacho too.

Steps To Reproduce

"C:\Program Files\Java\jdk1.8.0_311\bin\java.exe" -javaagent:authlib-injector.jar=https://mcskin.cn/api/yggdrasil -Xmx3600M -Xms3072M -XX:+UseG1GC -XX:+ParallelRefProcEnabled -XX:MaxGCPauseMillis=200 -XX:+UnlockExperimentalVMOptions -XX:+DisableExplicitGC -XX:+AlwaysPreTouch -XX:G1NewSizePercent=30 -XX:G1MaxNewSizePercent=40 -XX:G1HeapRegionSize=8M -XX:G1ReservePercent=20 -XX:G1HeapWastePercent=5 -XX:G1MixedGCCountTarget=4 -XX:InitiatingHeapOccupancyPercent=15 -XX:G1MixedGCLiveThresholdPercent=90 -XX:G1RSetUpdatingPauseTimePercent=5 -XX:SurvivorRatio=32 -XX:+PerfDisableSharedMem -XX:MaxTenuringThreshold=1 -XX:+AggressiveOpts -Dlog4j2.formatMsgNoLookups=true -jar NachoSpigot.jar Enter with any client , then disconnect.

Plugin List

No response

Server Version

This server is running NachoSpigot version git-NachoSpigot-"3f69c24" (MC: 1.8.8) (Implementing API version 1.8.8-R0.2-SNAPSHOT)

Other

No response

Agreements

HowardZHY commented 2 years ago

image

sadcenter commented 2 years ago

authlib wasn't touched in the nacho, isn't it authlib-injector fault?

HowardZHY commented 2 years ago

authlib wasn't touched in the nacho, isn't it authlib-injector fault?

Authlib-injector works well on Burrito. Someting breaks handshake (might see https://github.com/Bukkit/mc-dev/blob/master/net/minecraft/server/PacketSplitter.java )