search

CobbleSword / NachoSpigot

NachoSpigot is a fork of TacoSpigot 1.8.9 that offers several enhancements to performance as well as bug fixes.
GNU General Public License v3.0
237 stars 86 forks source link

[ProtocolLib] INTERNAL ERROR: Unable to inject incoming channel #362

Closed DrakMC closed 2 years ago

DrakMC commented 2 years ago

Observed Behavior

ProtocolLib not working with latest NachoSpigot. Error: https://pastebin.com/raw/wCm18sqk

Expected Behavior

To make ProtocolLib work again.

Steps To Reproduce

  1. Start server
  2. Error will show up in the console

Plugin List

No response

Server Version

git-NachoSpigot-"ec731d5" (MC: 1.8.8)

Other

No response

Agreements

HowardZHY commented 2 years ago

use java 8

CyberFlameGO commented 2 years ago

use java 8

iirc Java 15 works best on Nacho

crafter23456 commented 2 years ago

He uses an old Protocollib. 4.7.0 and not the latest 4.8.0. that causes the issue. You know we removed the Protocollib patch because 4.8.0 fixed it internally. I didn't had the issue when I tested it on 4.8.0

ghost commented 2 years ago

Observed Behavior

ProtocolLib not working with latest NachoSpigot. Error: https://pastebin.com/raw/wCm18sqk

Expected Behavior

To make ProtocolLib work again.

Steps To Reproduce

  1. Start server
  2. Error will show up in the console

Plugin List

No response

Server Version

git-NachoSpigot-"ec731d5" (MC: 1.8.8)

Other

No response

Agreements

  • [x] You were able to find this issue on the latest version of NachoSpigot.
  • [x] You have confirmed that there aren’t any issues open regarding this bug.

Like @crafter23456 said, you're using a old protocollib version, you need to use 4.8.0+

ghost commented 2 years ago

iirc Java 15 works best on Nacho

Java 17 works best and Java 15 is unsupported by JDK providers and no longer getting updates

He uses an old Protocollib. 4.7.0 and not the latest 4.8.0. that causes the issue. You know we removed the Protocollib patch because 4.8.0 fixed it internally. I didn't had the issue when I tested it on 4.8.0

4.8.0 is still a snapshot which isn’t on the spigot page and thus not many people will use it. Also the ProtocolLib patch was removed in 4.7.0, not 4.8.0

crafter23456 commented 2 years ago

iirc Java 15 works best on Nacho

Java 17 works best and Java 15 is unsupported by JDK providers and no longer getting updates

I still use LTS Java 11 because of #327

He uses an old Protocollib. 4.7.0 and not the latest 4.8.0. that causes the issue. You know we removed the Protocollib patch because 4.8.0 fixed it internally. I didn't had the issue when I tested it on 4.8.0

4.8.0 is still a snapshot which isn’t on the spigot page and thus not many people will use it. Also the ProtocolLib patch was removed in 4.7.0, not 4.8.0

Yeah it's called snapshot but it uses literary everybody on 1.18.1+ and some ppl which know that the jenkins exist. So we bump netty if it released to spigot "officially" and literary nobody should use 4.7.0? 4.7.0 is from 9th Jul 2021 so a bit old and misses some fixes.